Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsconfig.json - add packages/contracts #1013

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

qq7
Copy link
Collaborator

@qq7 qq7 commented May 8, 2024

without this line, running gsn deploy fails with Error: Cannot find module '@opengsn/contracts/types/ethers-contracts'
closes #1006

@qq7 qq7 requested a review from forshtat May 8, 2024 22:06
@forshtat
Copy link
Member

without this line, running gsn deploy fails with Error: Cannot find module '@opengsn/contracts/types/ethers-contracts' closes #1006

Unfortunately it appears that truffle is not able to install the solidity compiler any more, and given that truffle has been deprecated it is likely more things will break as well. So unless you can also fix this issue, merging this PR will not be useful until the migration to current frameworks is complete (#1012).

@qq7
Copy link
Collaborator Author

qq7 commented May 13, 2024

@forshtat

Unfortunately it appears that truffle is not able to install the solidity compiler any more

Ahh, I didn't check with 0.8.7... It compiled fine on my machine when I bumped solc version to 0.8.15. Let's give it a go on CircleCI...

@qq7
Copy link
Collaborator Author

qq7 commented May 13, 2024

This time it has worked. Might also make sense to bump solc version in paymasters package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npx gsn relayer-register breaks on @opengsn/[email protected]
2 participants