Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[transform.vat] Suppress warnings for NULL/UNDEF #15089

Merged
merged 1 commit into from
Jun 13, 2023
Merged

[transform.vat] Suppress warnings for NULL/UNDEF #15089

merged 1 commit into from
Jun 13, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Jun 12, 2023

There is no reason to log warnings when source value is of type UnDefType:

2023-06-12 22:55:55.356 [WARN ] [at.internal.VATTransformationService] - Input value 'UNDEF' could not be converted to a valid number
2023-06-12 22:55:55.357 [WARN ] [nal.profile.VATTransformationProfile] - Could not apply 'VAT' transformation on state 'UNDEF' with value '25'.
2023-06-12 22:55:55.357 [DEBUG] [nal.profile.VATTransformationProfile] - Transformed 'UNDEF' into 'UNDEF'

Regression from #14529

@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. labels Jun 12, 2023
J-N-K
J-N-K approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@J-N-K J-N-K merged commit 3cfb048 into openhab:main Jun 13, 2023
@J-N-K J-N-K added this to the 4.0 milestone Jun 13, 2023
@jlaur jlaur deleted the vat-undef branch June 13, 2023 18:41
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
@jlaur @tburri-alstom
[transform.vat] Suppress warnings for NULL/UNDEF (openhab#15089)
b502c57 
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Thomas Burri <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
@jlaur @matchews
[transform.vat] Suppress warnings for NULL/UNDEF (openhab#15089)
596d2d2 
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Matt Myers <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@jlaur @austvik
[transform.vat] Suppress warnings for NULL/UNDEF (openhab#15089)
2907c3c 
Signed-off-by: Jacob Laursen <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jlaur @J-N-K