[basicprofiles] Add additional comparisons to State Filter profile #17323

jimtng · 2024-08-24T16:58:39Z

Add inequality comparisons to State Filter profile
Support symbolic operators ==, !=, etc.
Fix a bug where undefined mismatchState passed UNDEF instead of ignoring state updates
Support multiline conditions
Support comparing against the input state from handler to filter out
unwanted data
Support comparing the states of item1 vs item2
Support comparing the input state against another item's state

https://community.openhab.org/t/state-filter-range-filter-profile/158025

openhab-bot · 2024-08-25T15:56:43Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/state-filter-profile/158025/1

- Fix bug where undefined `mismatchState` passed `UNDEF` instead of ignoring state updates - Support multiline conditions - Support comparing against the input state from handler to filter out unwanted data Signed-off-by: Jimmy Tanagra <[email protected]>

jlaur · 2024-08-26T17:59:11Z

@J-N-K - would you like to add yourself to CODEOWNERS for basicprofiles? I missed this in #16754.

openhab-bot · 2024-08-26T19:41:33Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/filter-transform-energy-meter-readings-to-delete-single-readings-for-state-machine/156276/7

Unquoted identifiers can refer to other items or have other meanings. Signed-off-by: Jimmy Tanagra <[email protected]>

Signed-off-by: Jimmy Tanagra <[email protected]>

J-N-K

In general: nice addition.

J-N-K · 2024-08-27T18:35:09Z

bundles/org.openhab.transform.basicprofiles/README.md

@@ -27,13 +27,13 @@ Switch lightsStatus {

 The Generic Toggle Switch Profile is a specialization of the Generic Command Profile and toggles the State of a Switch Item whenever one of the specified events is triggered.

-### Configuration
+### Generic Toggle Switch Profile Configuration


Why did you change that? Isn't this already clear by the structure (## denotes the profile, ### the section within that profile)

I followed the markdown warning that the headings should be unique.

This makes the anchor links better, but it's a very obscure benefit perhaps. Without this, the links would look like #configuration-1, #configuration-2, etc.

Should I revert this?

J-N-K · 2024-08-27T18:38:21Z

bundles/org.openhab.transform.basicprofiles/README.md

+
+- The operator names must be surrounded by spaces, i.e.: `Item EQ 10`
+- The operator symbols do not need to be surrounded by spaces, e.g.: `Item==10` and `Item == 10` are both fine.
+- Only symbolic operators can be used when comparing against the incoming state, e.g. `> 10`. Using operator names isn't supported, i.e. this is not supported: ~~`GT 10`~~.


Why is that?

The regex is more complicated to support it, but I've redone it now. Is it worth the extra complexity?

.../src/main/java/org/openhab/transform/basicprofiles/internal/profiles/StateFilterProfile.java

J-N-K · 2024-08-27T18:50:25Z

.../src/main/java/org/openhab/transform/basicprofiles/internal/profiles/StateFilterProfile.java

+                    }
+                }
+
+                rhs = Objects.requireNonNull(parsedValue instanceof StringType ? parsedValue.toString() : parsedValue);


Why do you need Objects.requireNonNull here? If parsedValue==null you exit in the if-clause above.

The compiler complained about null mismatch further down in the calls to compareTo(rhs).

.../src/main/java/org/openhab/transform/basicprofiles/internal/profiles/StateFilterProfile.java

support named operator for input checking Signed-off-by: Jimmy Tanagra <[email protected]>

J-N-K

Thanks! Nice to see so many tests.

…penhab#17323) * Add inequality comparisons to State Filter profile - Fix bug where undefined `mismatchState` passed `UNDEF` instead of ignoring state updates - Support multiline conditions - Support comparing against the input state from handler to filter out unwanted data * Support comparing item to item or input to item Signed-off-by: Jimmy Tanagra <[email protected]>

…penhab#17323) * Add inequality comparisons to State Filter profile - Fix bug where undefined `mismatchState` passed `UNDEF` instead of ignoring state updates - Support multiline conditions - Support comparing against the input state from handler to filter out unwanted data * Support comparing item to item or input to item Signed-off-by: Jimmy Tanagra <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>

jimtng requested a review from a team as a code owner August 24, 2024 16:58

jimtng added bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on labels Aug 24, 2024

jimtng marked this pull request as draft August 24, 2024 17:00

jimtng force-pushed the basicprofile-statefilter branch from ecb7cac to 4d382a7 Compare August 25, 2024 15:43

jimtng removed bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on labels Aug 25, 2024

jimtng force-pushed the basicprofile-statefilter branch 2 times, most recently from be83319 to d68a005 Compare August 25, 2024 16:04

jimtng force-pushed the basicprofile-statefilter branch from d68a005 to ed2b1c7 Compare August 25, 2024 16:31

jimtng added the enhancement An enhancement or new feature for an existing add-on label Aug 25, 2024

jimtng marked this pull request as ready for review August 26, 2024 02:05

jlaur requested a review from J-N-K August 26, 2024 17:59

jimtng marked this pull request as draft August 27, 2024 08:19

jimtng added 2 commits August 27, 2024 19:12

String values / constants must always be quoted

1afa46e

Unquoted identifiers can refer to other items or have other meanings. Signed-off-by: Jimmy Tanagra <[email protected]>

Support comparing item to item or input to item

6a76975

Signed-off-by: Jimmy Tanagra <[email protected]>

jimtng mentioned this pull request Aug 27, 2024

Make DateTimeType Comparable openhab/openhab-core#4364

Merged

jimtng marked this pull request as ready for review August 27, 2024 12:48

J-N-K requested changes Aug 27, 2024

View reviewed changes

jimtng force-pushed the basicprofile-statefilter branch from a41d781 to a93556c Compare August 28, 2024 03:11

jimtng marked this pull request as draft August 28, 2024 03:29

jimtng force-pushed the basicprofile-statefilter branch 2 times, most recently from 16aa71f to 4d878eb Compare August 28, 2024 06:10

jimtng marked this pull request as ready for review August 28, 2024 06:27

support <> operator.

00035da

support named operator for input checking Signed-off-by: Jimmy Tanagra <[email protected]>

jimtng force-pushed the basicprofile-statefilter branch from 4d878eb to 00035da Compare August 28, 2024 06:30

jimtng added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Aug 28, 2024

J-N-K approved these changes Aug 28, 2024

View reviewed changes

J-N-K added this to the 4.3 milestone Aug 28, 2024

J-N-K merged commit e4ce954 into openhab:main Aug 28, 2024
5 checks passed

J-N-K changed the title ~~[basicprofiles] Add inequality comparisons to State Filter profile~~ [basicprofiles] Add additional comparisons to State Filter profile Aug 28, 2024

jimtng deleted the basicprofile-statefilter branch August 28, 2024 14:33

jimtng mentioned this pull request Aug 29, 2024

[basicprofiles] Fix statefilter check against item's value on the rhs #17346

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[basicprofiles] Add additional comparisons to State Filter profile #17323

[basicprofiles] Add additional comparisons to State Filter profile #17323

jimtng commented Aug 24, 2024 •

edited

Loading

openhab-bot commented Aug 25, 2024

jlaur commented Aug 26, 2024

openhab-bot commented Aug 26, 2024

J-N-K left a comment

J-N-K Aug 27, 2024

jimtng Aug 28, 2024

J-N-K Aug 27, 2024

jimtng Aug 28, 2024 •

edited

Loading

J-N-K Aug 27, 2024

jimtng Aug 28, 2024

J-N-K left a comment

[basicprofiles] Add additional comparisons to State Filter profile #17323

[basicprofiles] Add additional comparisons to State Filter profile #17323

Conversation

jimtng commented Aug 24, 2024 • edited Loading

openhab-bot commented Aug 25, 2024

jlaur commented Aug 26, 2024

openhab-bot commented Aug 26, 2024

J-N-K left a comment

Choose a reason for hiding this comment

J-N-K Aug 27, 2024

Choose a reason for hiding this comment

jimtng Aug 28, 2024

Choose a reason for hiding this comment

J-N-K Aug 27, 2024

Choose a reason for hiding this comment

jimtng Aug 28, 2024 • edited Loading

Choose a reason for hiding this comment

J-N-K Aug 27, 2024

Choose a reason for hiding this comment

jimtng Aug 28, 2024

Choose a reason for hiding this comment

J-N-K left a comment

Choose a reason for hiding this comment

jimtng commented Aug 24, 2024 •

edited

Loading

jimtng Aug 28, 2024 •

edited

Loading