Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple binding markdown fixes #17422

Merged
merged 12 commits into from
Sep 28, 2024
Merged

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Sep 15, 2024

  • Fixes some SAT warnings about markdown.
  • Reformatted some tables. (no change to content, just whitespaces)
  • Fixes some icons missing in the docs folder cuasing 404's.
  • Fixes some duplicate headers in the docs, causing anchor tags to fail.
  • Adjusted all lists to dashes
  • Removed all trailing whitespaces
  • Added ini language to some configuraiton related code fences

Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
bundles/org.openhab.binding.warmup/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.io.homekit/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.io.openhabcloud/README.md Outdated Show resolved Hide resolved
Signed-off-by: Leo Siepel <[email protected]>
@holgerfriedrich
Copy link
Member

Overall, LGTM, thanks for caring!

I share the doubts with perl code formatting, but I have not checked the rendering. Maybe not a problem at all - though we typically use java formatting, right?

The question is if we should change meteoalerte (as my impression is that it should be replaced by metrofrance, correct me if I am wrong).

@lsiepel
Copy link
Contributor Author

lsiepel commented Sep 21, 2024

Overall, LGTM, thanks for caring!

I share the doubts with perl code formatting, but I have not checked the rendering. Maybe not a problem at all - though we typically use java formatting, right?

I can revert those perl changes and maybe @wborn can add anything to it as he previously created the base in the linked post for these languages. As Java uses a different comment tag I would opt not to use that case fence language.

The question is if we should change meteoalerte (as my impression is that it should be replaced by metrofrance, correct me if I am wrong).

I’ll revert changes to that one as we are about to finish the change from meteoalerte to meteofrance with @clinique

@holgerfriedrich this is the difference between perl and java for these blocks:
image

Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel
Copy link
Contributor Author

lsiepel commented Sep 21, 2024

Reverted the perl blocks as these are doubts and reverted meteoalerte.
Please merge to prevent conflicts as it touches multiple bindings.

@lsiepel
Copy link
Contributor Author

lsiepel commented Sep 22, 2024

Build fail is not related @lolodomo

@lsiepel
Copy link
Contributor Author

lsiepel commented Sep 27, 2024

@openhab/add-ons-maintainers I prefer not to go though conflict resolving so if you have some time, please merge.

Signed-off-by: Leo Siepel <[email protected]>
Copy link
Contributor

@morph166955 morph166955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM AndroidTV and Neeo

@lsiepel
Copy link
Contributor Author

lsiepel commented Sep 28, 2024

Last commit is about removing trailing spaces using the regex "\s+$" 1189 occurences are fixed. I checked 15-20% and could not finde any reason why these whitespaces should be left in.

Signed-off-by: Leo Siepel <[email protected]>
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM growatt
LGTM hue
LGTM neohub

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM evcc

Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nanoleaf and Govee look good to me

Copy link
Contributor

@mlobstein mlobstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Many thanks for the major cleanup.

@jlaur jlaur merged commit 1a42353 into openhab:main Sep 28, 2024
4 of 5 checks passed
@jlaur jlaur added this to the 4.3 milestone Sep 28, 2024
@lsiepel lsiepel deleted the documentation-fixes branch September 28, 2024 16:09
Copy link
Member

@druciak druciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Satel looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.