[shelly] Add support for Shelly BLU Gateway Gen3 #18174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markus Michels <[email protected]>
markus7017
added
the
enhancement
Signed-off-by: Markus Michels <[email protected]>
lsiepel
reviewed
Jan 24, 2025
| @@ -1607,6 +1609,7 @@ See notes on discovery of Shelly BLU devices above. | |||
| | battery | batteryLevel | Number | yes | Battery Level in % | | |||
| | | lowBattery | Switch | yes | Low battery alert (< 20%) | | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
correct, I could if required create another PR
There was a problem hiding this comment.
That would be best, thanks!
|
Will this also support BLU TRVs? |
jlaur
requested changes
Jan 25, 2025
| @@ -304,13 +304,17 @@ public static DateTimeType getTimestamp(String zone, long timestamp) { | |||
| ZoneId zoneId = !zone.isEmpty() ? ZoneId.of(zone) : ZoneId.systemDefault(); | |||
| ZonedDateTime zdt = LocalDateTime.now().atZone(zoneId); | |||
| int delta = zdt.getOffset().getTotalSeconds(); | |||
| return new DateTimeType(Instant.ofEpochSecond(timestamp - delta)); | |||
| return new DateTimeType(ZonedDateTime.ofInstant(Instant.ofEpochSecond(timestamp - delta), zoneId)); | |||
| @@ -345,7 +345,7 @@ private void addAttribute(Map<String, String> properties, ShellyManagerInterface | |||
| value = dateTimeState.format(null).replace('T', ' ').replace('-', '/'); | |||
| break; | |||
| default: | |||
| value = dateTimeState.format(null).replace('T', ' ').replace('-', '/'); | |||
| value = getTimestamp(dateTimeState); | |||
There was a problem hiding this comment.
Why this change here, but not in line 345? What is the desired format, do you actually want to use DateTimeType for formatting (openHAB), or ZonedDateTime (Java)?
In any case, not related to adding new device support, and looks like a half overwrite of 03a0993.
jlaur
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new device