Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide unit hints for rpm channels #18175

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Jan 24, 2025

This ensures that the UI will suggest "rpm" rather than "Hz" when creating new items.

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Jan 24, 2025
Copy link
Contributor

@boehan boehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for comfoair

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@lsiepel lsiepel added this to the 5.0 milestone Jan 24, 2025
@lsiepel lsiepel merged commit 31486a9 into openhab:main Jan 24, 2025
2 checks passed
@jlaur jlaur deleted the rpm-unit-hints branch January 24, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants