Adopt reviewer suggestions

Signed-off-by: Andrew Fiddian-Green <[email protected]>
openhab · Dec 22, 2023 · bd2e8f0 · bd2e8f0
1 parent da4b488
commit bd2e8f0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 22 deletions.
diff --git a/...y.addon.usb/src/main/java/org/openhab/core/config/discovery/addon/usb/UsbAddonFinder.java b/...y.addon.usb/src/main/java/org/openhab/core/config/discovery/addon/usb/UsbAddonFinder.java
@@ -16,7 +16,6 @@
 import static org.openhab.core.config.discovery.addon.AddonFinderConstants.SERVICE_TYPE_USB;
 
 import java.util.HashSet;
-import java.util.List;
 import java.util.Map;
 import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
@@ -32,9 +31,7 @@
 import org.openhab.core.config.discovery.usbserial.UsbSerialDeviceInformation;
 import org.openhab.core.config.discovery.usbserial.UsbSerialDiscovery;
 import org.openhab.core.config.discovery.usbserial.UsbSerialDiscoveryListener;
-import org.osgi.service.component.annotations.Activate;
 import org.osgi.service.component.annotations.Component;
-import org.osgi.service.component.annotations.Deactivate;
 import org.osgi.service.component.annotations.Reference;
 import org.osgi.service.component.annotations.ReferenceCardinality;
 import org.osgi.service.component.annotations.ReferencePolicy;
@@ -66,14 +63,6 @@ public class UsbAddonFinder extends BaseAddonFinder implements UsbSerialDiscover
     private final Set<UsbSerialDiscovery> usbSerialDiscoveries = new CopyOnWriteArraySet<>();
     private final Map<Integer, UsbSerialDeviceInformation> usbDeviceInformations = new ConcurrentHashMap<>();
 
-    @Activate
-    public UsbAddonFinder() {
-    }
-
-    @Deactivate
-    public void deactivate() {
-    }
-
     @Reference(cardinality = ReferenceCardinality.MULTIPLE, policy = ReferencePolicy.DYNAMIC)
     protected void addUsbSerialDiscovery(UsbSerialDiscovery usbSerialDiscovery) {
         usbSerialDiscoveries.add(usbSerialDiscovery);
@@ -86,16 +75,6 @@ protected synchronized void removeUsbSerialDiscovery(UsbSerialDiscovery usbSeria
         usbSerialDiscoveries.remove(usbSerialDiscovery);
     }
 
-    @Override
-    public void setAddonCandidates(List<AddonInfo> candidates) {
-        super.setAddonCandidates(candidates);
-    }
-
-    @Override
-    public void unsetAddonCandidates() {
-        super.unsetAddonCandidates();
-    }
-
     @Override
     public Set<AddonInfo> getSuggestedAddons() {
         Set<AddonInfo> result = new HashSet<>();

diff --git a/...on.usb/src/test/java/org/openhab/core/config/discovery/addon/usb/UsbAddonFinderTests.java b/...on.usb/src/test/java/org/openhab/core/config/discovery/addon/usb/UsbAddonFinderTests.java
@@ -34,7 +34,7 @@
 import ch.qos.logback.classic.Level;
 
 /**
- * This contains Junit tests for the {@link UsbAddonFinder} class.
+ * This contains tests for the {@link UsbAddonFinder} class.
  *
  * @author Andrew Fiddian-Green - Initial contribution
  */