Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit "calorie" #3684

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Add unit "calorie" #3684

merged 1 commit into from
Jul 15, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jul 3, 2023

Closes #3667

@J-N-K
Add unit "calorie"
eb75ce8 
Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Jul 3, 2023
@J-N-K J-N-K requested a review from a team as a code owner July 3, 2023 19:00
@J-N-K J-N-K added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Jul 4, 2023
wborn
wborn approved these changes Jul 15, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 9ba8e71 into openhab:main Jul 15, 2023
2 checks passed
@wborn wborn added this to the 4.0 milestone Jul 15, 2023
@wborn
Copy link
Member

wborn commented Jul 15, 2023

Can you also add the new unit to the UoM docs?

https://next.openhab.org/docs/concepts/units-of-measurement.html

@wborn wborn added the UoM Units of Measurement label Jul 15, 2023
@wborn
Copy link
Member

wborn commented Jul 15, 2023

I think these units also still need to be added to the docs:

@J-N-K J-N-K deleted the feature-calorie branch July 16, 2023 07:48
boehan added a commit to boehan/openhab-docs that referenced this pull request Jul 16, 2023
@boehan
add new units to docs
0fde030 
Related to openhab/openhab-core#3608
Related to openhab/openhab-core#3616
Related to openhab/openhab-core#3684

Signed-off-by: Hans Böhm <[email protected]>
@boehan boehan mentioned this pull request Jul 16, 2023
Merged
@boehan
Copy link
Contributor

boehan commented Jul 16, 2023

I think these units also still need to be added to the docs:

* [Add dimension RadiationSpecificActivity #3608](https://github.com/openhab/openhab-core/pull/3608)

* [[UoM] add unit rpm for rotational frequency #3616](https://github.com/openhab/openhab-core/pull/3616)

Done in openhab/openhab-docs#2100

Confectrician pushed a commit to openhab/openhab-docs that referenced this pull request Jul 16, 2023
@boehan
add new units to docs (#2100)
8759b4b 
Related to openhab/openhab-core#3608
Related to openhab/openhab-core#3616
Related to openhab/openhab-core#3684

Signed-off-by: Hans Böhm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core UoM Units of Measurement
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

[UoM] add unit cal as energy
3 participants
@J-N-K @wborn @boehan