Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid item not found warning from UIRegistry #3686

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Avoid item not found warning from UIRegistry #3686

merged 1 commit into from
Jul 5, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Jul 5, 2023

Fix openhab/openhab-webui#1951

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo requested a review from a team as a code owner July 5, 2023 17:29
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-0-milestone-discussion/145133/517

J-N-K
J-N-K approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question: Why is there a widget that has no item name at all?

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Jul 5, 2023
@lolodomo
Copy link
Contributor Author

lolodomo commented Jul 5, 2023

Why is there a widget that has no item name at all?

A frame widget is an example of widget without item. But the item is also optional for an image widget or a video widget for examples.

@J-N-K J-N-K merged commit b2934ad into openhab:main Jul 5, 2023
2 checks passed
@J-N-K J-N-K changed the title Avoid warning log introduced by PR #3644 Avoid item not found warning from UIRegistry Jul 5, 2023
@J-N-K J-N-K added this to the 4.0 milestone Jul 5, 2023
@lolodomo lolodomo deleted the uiregistry_fix_log_level branch July 5, 2023 18:16
@lolodomo lolodomo mentioned this pull request Jul 5, 2023
Closed
4 tasks
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@lolodomo @splatch
Avoid warning log introduced by PR openhab#3644 (openhab#3686)
6eee3a4 
Fix openhab/openhab-webui#1951

Signed-off-by: Laurent Garnier <[email protected]>
GitOrigin-RevId: b2934ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

[Basic UI] Frames generate errors with null items
3 participants
@lolodomo @openhab-bot @J-N-K