Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP audio servlet: check end of play every 2 seconds #3695

Merged
merged 1 commit into from
Jul 11, 2023
Merged

HTTP audio servlet: check end of play every 2 seconds #3695

merged 1 commit into from
Jul 11, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Jul 8, 2023

Instead of 5s before.
It helps triggering the end of playback earlier for audio sinks in asynchronous mode.

Signed-off-by: Laurent Garnier [email protected]

@lolodomo
HTTP audio servlet: check end of play every 2 seconds
cdac8a7 
Instead of 5s before.
It helps triggering the end of playback earlier for audio sinks in asynchronous mode.

Signed-off-by: Laurent Garnier <[email protected]>
@lolodomo lolodomo requested a review from a team as a code owner July 8, 2023 10:29
@lolodomo
Copy link
Contributor Author

lolodomo commented Jul 8, 2023

@dalgwen or any @openhab/core-maintainers for approval.

@J-N-K
Copy link
Member

J-N-K commented Jul 9, 2023

Is this really the best way to figure out if a stream has finished playing?

@lolodomo
Copy link
Contributor Author

lolodomo commented Jul 9, 2023

Is this really the best way to figure out if a stream has finished playing?

As @dalgwen said, it is not perfect but it is what we currently have.

@dalgwen
Copy link
Contributor

dalgwen commented Jul 9, 2023

Is this really the best way to figure out if a stream has finished playing?

I, too, would like to find something better and I'm open to suggestion.

See my explanation here for how it is currently implemented.

J-N-K
J-N-K approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@J-N-K J-N-K merged commit f0adf76 into openhab:main Jul 11, 2023
2 checks passed
@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Jul 11, 2023
@J-N-K J-N-K added this to the 4.0 milestone Jul 11, 2023
@lolodomo lolodomo deleted the audiosink_checkend_frequency branch July 11, 2023 16:49
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@lolodomo @splatch
HTTP audio servlet: check end of play every 2 seconds (openhab#3695)
7eb81b1 
Instead of 5s before.
It helps triggering the end of playback earlier for audio sinks in asynchronous mode.

Signed-off-by: Laurent Garnier <[email protected]>
GitOrigin-RevId: f0adf76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lolodomo @J-N-K @dalgwen