Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sitemap UI] Do not break format defined in label with extra spaces #3708

Merged
merged 1 commit into from
Jul 17, 2023
Merged

[Sitemap UI] Do not break format defined in label with extra spaces #3708

merged 1 commit into from
Jul 17, 2023

Conversation

lolodomo
Copy link
Contributor

Fix openhab/openhab-webui#1953

Fix a regression introduced by PR #3644

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo requested a review from a team as a code owner July 17, 2023 14:55
@lolodomo
Copy link
Contributor Author

With these items

Number:Temperature CurrentTemp "Current Temp [%.1f °C]" <none> (GTest1,GTest) [ "Measurement", "Temperature" ]
Number TestNumber "Test number [%.2f]" (GTest1)

and this sitemap

sitemap test3 label="Tests"
{
	Frame label="Text state pattern" {
		Default item=CurrentTemp
		Default item=CurrentTemp label="Current Temp [%.1f °]"
		Default item=CurrentTemp label="Current Temp [%.1f°]"
		Default item=CurrentTemp label="Current Temp [%.1f Abcde]"
		Default item=CurrentTemp label="Current Temp [%.1fAbcde]"
		Default item=TestNumber
		Default item=TestNumber label="Test number [%.2f %%]"
		Default item=TestNumber label="Test number [%.2f%%]"
	}
}

image

@lolodomo
Copy link
Contributor Author

@openhab/core-maintainers : please merge this PR fixing a recent regression before releasing OH4 RC1.

J-N-K
J-N-K approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Jul 17, 2023
@J-N-K J-N-K added this to the 4.0 milestone Jul 17, 2023
@J-N-K J-N-K merged commit f711373 into openhab:main Jul 17, 2023
2 checks passed
@lolodomo lolodomo deleted the fix_extra_space branch July 17, 2023 16:55
@jlaur jlaur mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

[Sitemap UI] Extra space for item state with Number: items
2 participants
@lolodomo @J-N-K