Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REST] Check a label is provided when creating a new semantic tag #3734

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[REST] Check a label is provided when creating a new semantic tag #3734

merged 1 commit into from
Aug 16, 2023

Conversation

lolodomo
Copy link
Contributor

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo requested a review from a team as a code owner July 29, 2023 08:59
@lolodomo
Copy link
Contributor Author

@openhab/core-maintainers : this is only 5 lines of code, can one of you please review & merge ?

wborn
wborn approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the check @lolodomo

@wborn wborn merged commit 5f8658d into openhab:main Aug 16, 2023
2 checks passed
@wborn wborn added this to the 4.1 milestone Aug 16, 2023
@wborn wborn added bug An unexpected problem or unintended behavior of the Core REST/SSE labels Aug 16, 2023
@lolodomo lolodomo deleted the semantic_label_provided branch August 16, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core REST/SSE
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@lolodomo @wborn