Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging in AbstractProvider implementations #3751

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Fix logging in AbstractProvider implementations #3751

merged 1 commit into from
Aug 13, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Aug 12, 2023

Implementations should not use the logger of the parent

@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Aug 12, 2023
@J-N-K J-N-K requested a review from a team as a code owner August 12, 2023 09:52
wborn
wborn approved these changes Aug 13, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wborn wborn merged commit 3af2e30 into openhab:main Aug 13, 2023
2 checks passed
@wborn wborn added this to the 4.1 milestone Aug 13, 2023
@J-N-K J-N-K deleted the fix-logger branch August 13, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@J-N-K @wborn