Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GenericThingProvider #3779

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Aug 26, 2023

When things from multiple handler factories are provisioned from the same file the internal thing map was not properly updated.

When things from multiple handler factories are provisioned from the same file the internal thing map was not properly updated.

Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Aug 26, 2023
@J-N-K J-N-K requested a review from a team as a code owner August 26, 2023 13:06
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/4-0-1-cannot-delete-things-that-are-provisioned-from-file/148518/27

@wborn wborn added rebuild Triggers the Jenkins PR build and removed rebuild Triggers the Jenkins PR build labels Aug 26, 2023
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Let's give it a test.

@wborn wborn merged commit b426ccc into openhab:main Aug 28, 2023
2 checks passed
@wborn wborn added this to the 4.1 milestone Aug 28, 2023
@J-N-K J-N-K deleted the fix-genericthiungprovider branch August 28, 2023 07:28
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh4-upgrade-issue/148009/24

wborn pushed a commit that referenced this pull request Sep 2, 2023
When things from multiple handler factories are provisioned from the same file the internal thing map was not properly updated.

Signed-off-by: Jan N. Klug <[email protected]>
@wborn wborn added the patch A PR that has been cherry-picked to a patch release branch label Sep 2, 2023
@andrewfg
Copy link
Contributor

@J-N-K I am not 100% sure but I think I also observe on OH 4.0.3 the same issue with my .items file (which contains items for all of my things). Could that be a similar issue? Or am I dreaming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants