Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unitHint to AbstractStorageBasedTypeProvider.ChannelTypeEntity #4317

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

pacive
Copy link
Member

@pacive pacive commented Jul 14, 2024

#4079 added a unitHint property to ChannelTypes, but the AbstractStorageBasedTypeProvider wasn't updated to reflect the change. This adds this property so it can be persisted when adding ChannelTypes dynamically.

Fixes #4315

Signed-off-by: Anders Alfredsson [email protected]

@pacive pacive requested a review from a team as a code owner July 14, 2024 15:01
@pacive pacive force-pushed the storagebasedtypeprovider-fix branch from 8c9b6e7 to 64c728b Compare July 14, 2024 15:02
Signed-off-by: Anders Alfredsson <[email protected]>
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of the Core label Jul 14, 2024
@J-N-K J-N-K merged commit 98554af into openhab:main Jul 14, 2024
5 checks passed
@J-N-K J-N-K added this to the 4.3 milestone Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbstractStorageBasedTypeProvider doesn't store unitHint
2 participants