Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing ScriptProfile parameter options #4360

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Add missing ScriptProfile parameter options #4360

merged 1 commit into from
Aug 21, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Aug 21, 2024 •
edited
Loading

for commandFromItemScript and stateFromItemScript
See #4058

This could perhaps be cherry picked to 4.2.x

@jimtng
Add missing ScriptProfile parameter options
c88b906 
for commandFromItemScript and stateFromItemScript

Signed-off-by: Jimmy Tanagra <[email protected]>
@jimtng jimtng requested a review from a team as a code owner August 21, 2024 15:39
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/syntax-for-binding-transformations/157861/19

florian-h05
florian-h05 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding it!
I will try to have a look at proposing transformations inside the state description metadata.

holgerfriedrich
holgerfriedrich approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerfriedrich holgerfriedrich merged commit b8e0f94 into openhab:main Aug 21, 2024
5 checks passed
@holgerfriedrich holgerfriedrich added the enhancement An enhancement or new feature of the Core label Aug 21, 2024
@holgerfriedrich holgerfriedrich added this to the 4.3 milestone Aug 21, 2024
@holgerfriedrich holgerfriedrich added bug An unexpected problem or unintended behavior of the Core and removed enhancement An enhancement or new feature of the Core labels Aug 21, 2024
@jimtng jimtng deleted the script-profile-parameters branch August 22, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@jimtng @openhab-bot @holgerfriedrich @florian-h05