Add XOR ArithmeticGroupFunction #4386
Merged
+138
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Vollmann <[email protected]>
wborn
changed the title
kaikreuzer
reviewed
Sep 25, 2024
| @@ -35,6 +35,7 @@ | |||
| * @author Kai Kreuzer - Initial contribution | |||
| * @author Thomas Eichstädt-Engelen - Added "N" functions | |||
| * @author Gaël L'hopital - Added count function | |||
| * @author Fabian Vollmann - Added ONE function | |||
There was a problem hiding this comment.
Why ONE? Don't you mean XOR?
kaikreuzer
reviewed
Sep 25, 2024
Comment on lines
217
to
218
| * This does a logical 'xor' operation. Only if items are of opposing 'activeState' and | ||
| * 'passiveState', 'activeState' is returned. For more than 2 states, this is '1 of n'. |
There was a problem hiding this comment.
Only if items are of opposing 'activeState' and 'passiveState', 'activeState' is returned
I do not fully get that statement. Could you try to reformulate it to make it clearer?
There was a problem hiding this comment.
I hope comment is easier to understand now
kaikreuzer
reviewed
Sep 25, 2024
There was a problem hiding this comment.
Thanks, lgtm apart from the two minor comments above.
May I also ask you to prepare a PR for the documentation update at https://github.com/openhab/openhab-docs/blob/main/configuration/items.md#derive-group-state-from-member-items?
Signed-off-by: Fabian Vollmann <[email protected]>
|
I also created a minor PR for the documentation update. Hope it is sufficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4385
PR provides a simple implementation for XOR. It uses "1 of n" for n > 2 (n = item count in group).