Extensive Refactoring

[michikrug]

First of all, sorry for that (probably) not reviewable PR in size.

I did an extensive refactoring of nearly all components.

The most important changes are:

• Restructured files so that each command and device has its own file
• Added newly structured tests and achieved >95% coverage
• Added automated lint, unit test, coverage reporting and security scanning with GitHub Actions
• Added new devices types like TV, Light with separate brightness/color (resolves Support color temperature for non-RGB lights #138), TemperatureSensor and Sensor (no idea how this works on the user's side)
• Includes all changes from Add support for Contact items for Locks and OpenClose devices #165, Add Temperature Sensor #172 and also Run tests with GitHub Actions #174 (Thanks to @Legion2)
• Changed tfaAck to ackNeeded and tfaPin to pinNeeded to be more in line with Googles attributes (former ones are kept for compatibility hopefully only during a migration phase)
• Updated dependencies
• And a lot of other changes, e.g. new attributes for some devices

---

If you struggle with approving this. Please let me know and we might find a way to slice this into smaller PRs.
But with everything tested now, I doubt that there will be any issues.

[michikrug]

@marziman I also worked on a workflow to automatically deploy to Google Cloud Functions on a pushed tag: michikrug#9

[marziman]

Ok lets speak about that too.
How about Tuesday 09:00 pm?

[michikrug]

Ok lets speak about that too.
How about Tuesday 09:00 pm?

@marziman let's do it: https://meet.google.com/ptn-iavo-gzr

[michikrug]

We definitely need to establish a better communication culture (or channel) here. Again, more than an hour "wasted" without notice. This kinda sucks. 😔

[marziman]

Hi @michikrug I am sorry, missed cause bringing kids to bed.
Maybe I will send you my nr or are you on slack?

[michikrug]

@marziman you may send me some contact details within the openhab community as a message to not expose too much personal data here

[marziman]

Already done. You have a message.
If I would have seen meesage early I eould not let you wait. Sorry again! 🙏🏻

[RaimondB]

I’d like to perform some test with these new features as I have motion sensors, lux, temperature and humidity sensors in multiple rooms that I would like to expose to google assistant. The first use case would be to use the motion detection to determine home or away status.

currently I am running the official version of openhab in docker. Can someone point me in the right direction to the steps I need to take to have these features available in my own version of openhab?

[michikrug]

I’d like to perform some test with these new features as I have motion sensors, lux, temperature and humidity sensors in multiple rooms that I would like to expose to google assistant. The first use case would be to use the motion detection to determine home or away status.

currently I am running the official version of openhab in docker. Can someone point me in the right direction to the steps I need to take to have these features available in my own version of openhab?

Hello. Since this integration is not part of the openHAB package itself, you would need to follow the instructions as stated in the README and set up an own version of openHAB cloud and this action.

[marziman]

Merging after video call...

[Ape]

@michikrug Should these new features already work on myopenhab.org since this has been merged?

[michikrug]

@michikrug Should these new features already work on myopenhab.org since this has been merged?

Negative. There will be an announcement by @marziman in the next days.

[nonamekl47]

Hello everyone, just a quick question as it seems that I'm missing something. Is this going to be available in openhab ? Or is it only for self hosted instances?

[michikrug]

As mentioned before this is not yet deployed and publicly available.

[nonamekl47]

@michikrug thanks for the clarification, that was my initial understanding but wasn't sure. Looking forward to seeing it go live.

[eikowagenknecht]

I see that you deliberately chose to keep the tags since you added some sentences in the documentation in that regard. I really think we should use this major refactoring and get rid of that compatibilty, it is confusing (GA binding reacts to a tag "homekit:TargetHeatingCoolingMode" for example), leads to errors (as you note in the docs) and the new way has been around for quite some time now. When will be a better time to get rid of this than now? :-)

Also default.js still has "hwVersion" and "swVersion" on "2.5.0". I think this deserves a bump to "3.0" ;-)

[michikrug]

@eikowagenknecht I discussed that with Marziman and we definitely want to get rid of tags. There is already an announcement in the openHAB community where we want to give the users a bit of time to adjust their configuration. A PR to remove the stuff is also open #194.

I think I touched the version also in some other PR...

[eikowagenknecht]

Ah sorry, didn't see that that was already taken care of :-)

One more thing I stumbled upon when I synced the code up with the metadata UI:

You added the parameters "discreteOnlyOpenClose" and "queryOnlyOpenClose". Wouldn't it make sense to generalize this to "discreteOnly" and "queryOnly" since it can also be used in other GA Traits (that are currently not yet implemented, https://developers.google.com/assistant/smarthome/traits/energystorage for example)?

[michikrug]

Ah sorry, didn't see that that was already taken care of :-)

One more thing I stumbled upon when I synced the code up with the metadata UI:

You added the parameters "discreteOnlyOpenClose" and "queryOnlyOpenClose". Wouldn't it make sense to generalize this to "discreteOnly" and "queryOnly" since it can also be used in other GA Traits (that are currently not yet implemented, developers.google.com/assistant/smarthome/traits/energystorage for example)?

Sounds reasonable, will just do it

[eikowagenknecht]

Great, I also added / changed this in my PR for the metadata UI.

[JohannesPtaszyk]

Is this PR already deployed?

[michikrug]

Is this PR already deployed?

No

[Ape]

Looks like this has now been deployed.

[michikrug]

Yes. There was already an announcement in the official openHAB community. https://community.openhab.org/t/openhab-google-assistant-new-release-with-updated-device-support/121143/2