Adjust Fan to use supportsFanSpeedPercent option #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michikrug
force-pushed
the
fan-percent
branch
from
dba9514
to
8232dc8
Compare
michikrug
force-pushed
the
fan-percent
branch
from
5230cad
to
90255d3
Compare
Signed-off-by: Michael Krug <[email protected]>
Signed-off-by: Michael Krug <[email protected]>
Signed-off-by: Michael Krug <[email protected]>
michikrug
force-pushed
the
fan-percent
branch
from
90255d3
to
c295e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in https://developers.home.google.com/cloud-to-cloud/traits/fanspeed#device-attributes there is now a new option called
supportsFanSpeedPercentthat should be set to true if no speeds are defined.This PR adds this option in case the devices is coming from a
Dimmeritem and does not provide aspeedsconfig.To actually set the speed in percent, the new command SetFanSpeed with the parameter
fanSpeedPercentis added.This is also reflected in the state reporting that now either reports the percentage or settings value.