[tests] Add unit tests to existing codebase #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Friedle <[email protected]>
Signed-off-by: Stefan Friedle <[email protected]>
Signed-off-by: Stefan Friedle <[email protected]>
Signed-off-by: Stefan Friedle <[email protected]>
Signed-off-by: Stefan Friedle <[email protected]>
Signed-off-by: Stefan Friedle <[email protected]>
Signed-off-by: Stefan Friedle <[email protected]>
Signed-off-by: Stefan Friedle <[email protected]>
Signed-off-by: Stefan Friedle <[email protected]>
The Jest mock functions and spies are now closer to their callers. java.mock.js is now independent of Jest. Signed-off-by: Stefan Friedle <[email protected]>
Signed-off-by: Stefan Friedle <[email protected]>
Signed-off-by: Stefan Friedle <[email protected]>
florian-h05
approved these changes
Nov 28, 2022
Signed-off-by: Stefan Friedle <[email protected]>
Signed-off-by: Stefan Friedle <[email protected]>
|
@florian-h05 Shall we merge and close this pull request? The contained tests cover nearly all JavaScript files in the root directory. I can open new pull requests when I continue to write tests for the remaining files in subdirectories, like |
|
I‘ll have a final look later, but I am very happy with merging this first PR! |
florian-h05
approved these changes
Dec 2, 2022
florian-h05
changed the title
florian-h05
pushed a commit
that referenced
this pull request
Dec 2, 2022
Relates to #166. * Add Jest dependencies and configuration. * Add tests for utils.js. * Add tests for triggers.js. * Add tests for cache.js. * Refactor mocking of global Java types. * Ignore .DS_Store. * Reorganize npm test scripts. * Move Jest mock functions. The Jest mock functions and spies are now closer to their callers. java.mock.js is now independent of Jest. * Add tests for osgi.js. * Add tests for actions.js. Signed-off-by: Stefan Friedle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #166
Description
This PR adds unit tests to the existing codebase. Until now there are only two unit tests, written with Mocha. The newly added tests use Jest as testing framework. To distinguish between the Mocha and Jest tests, we use this filename pattern:
*.test.js*.spec.jsThe tests can be run with this commands:
npm run testruns all tests and lints the sources.npm run test:mocharuns the existing Mocha tests.npm run test:jestruns the new Jest tests.