Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence editor: Remove checks on save as not required anymore #1988

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Jul 25, 2023

openhab/openhab-core#3727 made core handle null as values for relative and inverted fields of persistence filters and set defaults for those. Therefore, UI does not need to ensure they are set anymore.

openhab/openhab-core#3727 made core accept null as values for `relative` and `inverted` fields of persistence filters and set defaults for those.
Therefore, UI does not need to ensure they are set anymore.

Signed-off-by: Florian Hotze <[email protected]>
@florian-h05 florian-h05 requested a review from a team as a code owner July 25, 2023 19:31
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jul 25, 2023
@relativeci
Copy link

relativeci bot commented Jul 25, 2023

Job #1083: Bundle Size — 15.75MiB (~-0.01%).

3e3140e(current) vs b72638d main#1082(baseline)

⚠️ Bundle contains 16 duplicate packages

Metrics (1 change)
                 Current
Job #1083
     Baseline
Job #1082
Initial JS 1.67MiB(~-0.01%) 1.67MiB
Initial CSS 608.89KiB 608.89KiB
Cache Invalidation 93.94% 93.94%
Chunks 219 219
Assets 689 689
Modules 1700 1700
Duplicate Modules 90 90
Duplicate Code 1.95% 1.95%
Packages 138 138
Duplicate Packages 15 15
Total size by type (2 changes)
                 Current
Job #1083
     Baseline
Job #1082
CSS 859.34KiB 859.34KiB
Fonts 526.1KiB 526.1KiB
HTML 1.23KiB 1.23KiB
IMG 140.74KiB 140.74KiB
JS 9.24MiB (~-0.01%) 9.24MiB
Media 295.6KiB 295.6KiB
Other 4.72MiB (~-0.01%) 4.72MiB

View job #1083 reportView main branch activity

@ghys ghys merged commit 59695c6 into openhab:main Jul 26, 2023
4 checks passed
@florian-h05 florian-h05 deleted the persistence-remove-checks branch July 26, 2023 15:27
@florian-h05 florian-h05 added this to the 4.1 milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants