Installation of knxd now uses knxd package from standard package repository #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerfriedrich
force-pushed
the
knxd-package
branch
from
9f0277a
to
860fc2d
Compare
mstormi
approved these changes
Oct 14, 2020
functions/packages.bash
Outdated
| @@ -396,27 +396,50 @@ find_setup() { | |||
| ## knxd_setup() | |||
| ## | |||
| knxd_setup() { | |||
| local introText="This will install and setup kndx (successor to eibd) as your EIB/KNX IP gateway and router to support your KNX bus system.\\n\\nThis routine was provided by 'Michels Tech Blog': https://bit.ly/3dzeoKh" | |||
| local successText="Setup was successful.\\n\\nPlease edit '/etc/default/knxd' to meet your interface requirements. For further information on knxd options, please type 'knxd --help'\\n\\nFurther details can be found under: https://bit.ly/3dzeoKh\\n\\nIntegration into openHAB 2 is described here: https://github.com/openhab/openhab/wiki/KNX-Binding" | |||
| local introText="This will install and setup kndx as your EIB/KNX IP gateway and router to support your KNX bus system.\\n\\nNOTE: You don't need this if you connect via an IP interfacte or router to your KNX installation. This package is to turn an USB or serial interface into an IP interface.\n\nNOTE: openHABian changed from building and installing latest source to installing the knxd package provided by several distrubutions." | |||
There was a problem hiding this comment.
will it also setup knxd? If no remove from this text
2 typos:
interfacte
distrubutions
There was a problem hiding this comment.
Ok, thanks. Wish I could find a spell checker for strings bash scripts....
Will merge once checks have completed.
holgerfriedrich
force-pushed
the
knxd-package
branch
2 times, most recently
from
299a89a
to
fa16c8a
Compare
…sitory Changed from building and installing latest source to installing the knxd package provided by several distrubutions. Package is available in Debian, Raspberry Pi OS, and Ubuntu (starting 20.04). Closes openhab#651. Added bats test case. Signed-off-by: Holger Friedrich <[email protected]>
holgerfriedrich
force-pushed
the
knxd-package
branch
from
fa16c8a
to
6f5cfd0
Compare
holgerfriedrich
changed the title
|
@mstormi I added a bats test. Is focal fossa always failing due to missing packages or did I introduce a problem here? |
|
You refer to the BATS tests on Ubuntu ? It wasn't you. The test is new :) Issue #1161 is already open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed from building and installing latest source to installing the
knxd package provided by several distrubutions. Package is available
in Debian, Raspberry Pi OS, and Ubuntu (starting 20.04). Closes #651.
Added bats test case.
Signed-off-by: Holger Friedrich [email protected]