Stream ID, authorization header updates #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FragLegs
requested changes
Mar 2, 2025
| by the Receiver. | ||
| > If the endpoint_url requires authorization, the receiver is required to provide | ||
| this authorization header in the stream creation/updation. If present, the | ||
| Transmitter MUST set with each event delivery. |
There was a problem hiding this comment.
Suggested change
| Transmitter MUST set with each event delivery. | |
| Transmitter MUST use the authorization header with each event delivery. |
| > The HTTP Authorization header that the Transmitter MUST set with each event | ||
| delivery, if the configuration is present. The value is optional and it is set | ||
| by the Receiver. | ||
| > If the endpoint_url requires authorization, the receiver is required to provide |
There was a problem hiding this comment.
Suggested change
| > If the endpoint_url requires authorization, the receiver is required to provide | |
| > If the endpoint_url requires authorization, the receiver SHOULD provide |
| @@ -853,7 +854,8 @@ stream_id | |||
|
|
|||
| > **Transmitter-Supplied**, REQUIRED. A string that uniquely identifies the stream. A | |||
| Transmitter MUST generate a unique ID for each of its non-deleted streams | |||
| at the time of stream creation. | |||
| at the time of stream creation. Transmitters are recommended to use character set | |||
There was a problem hiding this comment.
Suggested change
| at the time of stream creation. Transmitters are recommended to use character set | |
| at the time of stream creation. Transmitters SHOULD use character set |
| @@ -853,7 +854,8 @@ stream_id | |||
|
|
|||
| > **Transmitter-Supplied**, REQUIRED. A string that uniquely identifies the stream. A | |||
| Transmitter MUST generate a unique ID for each of its non-deleted streams | |||
| at the time of stream creation. | |||
| at the time of stream creation. Transmitters are recommended to use character set | |||
| described in Section 2.3 of {{rfc3986}}}} to generate the stream ID. | |||
There was a problem hiding this comment.
Suggested change
| described in Section 2.3 of {{rfc3986}}}} to generate the stream ID. | |
| described in Section 2.3 of {{RFC3986}}}} to generate the stream ID. |
I don't know if capitalizing this matters, but it seems like the others are capitalized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #229 and #223