update go

Signed-off-by: Jared Tan <[email protected]>
openinsight-proj · Nov 8, 2024 · f03f36b · f03f36b
1 parent 7241e70
commit f03f36b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/.github/workflows/openinsight-release-packages.yaml b/.github/workflows/openinsight-release-packages.yaml
@@ -73,6 +73,8 @@ jobs:
           registry: ghcr.io
           username: ${{ github.repository_owner }}
           password: ${{ secrets.ACTIONS_TOKEN }}
+      - uses: actions/checkout@v4
+      - run: make genotelcontribcol
       - name: Build otel col contrib amd64
         run: GOOS=linux GOARCH=amd64 make otelcontribcol && cp ./bin/otelcontribcol_linux_amd64 ./cmd/otelcontribcol_linux_amd64
       - name: Build otel col contrib arm64

diff --git a/connector/tracedurationconnector/connector_logs.go b/connector/tracedurationconnector/connector_logs.go
@@ -117,6 +117,7 @@ func (c *logsConnector) exportTracesAsLogs(ctx context.Context, resourceSpans []
 	var traceId pcommon.TraceID
 	var spanId pcommon.SpanID
 	var stmp pcommon.Timestamp
+	// TODO: what the relation of resource after group
 	for i := 0; i < len(resourceSpans); i++ {
 		rspans := resourceSpans[i]
 		resourceAttr := rspans.Resource().Attributes()
@@ -142,6 +143,7 @@ func (c *logsConnector) exportTracesAsLogs(ctx context.Context, resourceSpans []
 					traceId = span.TraceID()
 					spanId = span.SpanID()
 					spanName = span.Name()
+					// get root span's start time as trace start time
 					stmp = span.StartTimestamp()
 				} else {
 					if minSpanStartTime == 0 || starTime < minSpanStartTime {

diff --git a/connector/tracedurationconnector/testdata/config.yaml b/connector/tracedurationconnector/testdata/config.yaml
@@ -50,6 +50,7 @@ exporters:
 
 processors:
   batch:
+  # dropping spans
   filter/ottl:
     error_mode: ignore
     traces: