Support storing the code that builds the code model #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we allow the user to decide how to store the code model. The first option is
TEXT
, if this is selected, we store the textual representation of the code model. The second option isCODE_BUILDR
, if this is selected, we store the code that builds the code model. All work done here is around the second option, because the first option is already supported.Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/305/head:pull/305
$ git checkout pull/305
Update a local copy of the PR:
$ git checkout pull/305
$ git pull https://git.openjdk.org/babylon.git pull/305/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 305
View PR using the GUI difftool:
$ git pr show -t 305
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/305.diff
Using Webrev
Link to Webrev Comment