-
Notifications
You must be signed in to change notification settings - Fork 30
Float4 arrayView support #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: code-reflection
Are you sure you want to change the base?
Conversation
|
👋 Welcome back rbrchen! A progress list of the required criteria for merging this PR into |
|
@rbrchen This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jjfumero) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work. I have a few comments/questions.
All test passing also for my setup (OpenCL backend).
Preliminary
Float4support for arrayViews. Currently only supported forF32ArrayPaddedbuffers, which can be accessed like aFloat4[]as shown below:At the moment, to use an element in the array, the
Float4must be loaded into a separate variable first, i.e.A value can be stored into the array through the following syntax:
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/646/head:pull/646$ git checkout pull/646Update a local copy of the PR:
$ git checkout pull/646$ git pull https://git.openjdk.org/babylon.git pull/646/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 646View PR using the GUI difftool:
$ git pr show -t 646Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/646.diff
Using Webrev
Link to Webrev Comment