Skip to content

Conversation

@rbrchen
Copy link
Contributor

@rbrchen rbrchen commented Oct 27, 2025

Preliminary Float4 support for arrayViews. Currently only supported for F32ArrayPadded buffers, which can be accessed like a Float4[] as shown below:

Float4[] arr = buffer.float4ArrayView(); // for a F32ArrayPadded buffer

At the moment, to use an element in the array, the Float4 must be loaded into a separate variable first, i.e.

Float4 a = arr[index * 4];

A value can be stored into the array through the following syntax:

arr[index * 4] = ...

Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/646/head:pull/646
$ git checkout pull/646

Update a local copy of the PR:
$ git checkout pull/646
$ git pull https://git.openjdk.org/babylon.git pull/646/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 646

View PR using the GUI difftool:
$ git pr show -t 646

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/646.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2025

👋 Welcome back rbrchen! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

@rbrchen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Float4 arrayView support

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the code-reflection branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jjfumero) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Copy link
Member

@jjfumero jjfumero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work. I have a few comments/questions.

All test passing also for my setup (OpenCL backend).

@rbrchen rbrchen marked this pull request as ready for review October 31, 2025 22:00
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 31, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants