8346768: [CRaC] Ignore errors parsing classpath

[TimPushkin]

CRaC's classpath parsing now ignores exceptions being thrown when parsing the paths.

ClasspathParseTest is extended to test the failure does not occur at least on Windows (no test case was found to trigger new File(...).toPath() exceptions on other platforms).

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8346768: [CRaC] Ignore errors parsing classpath (Bug - P4)

Reviewers

• Radim Vansa (@rvansa - Committer)

Contributors

• Timofei Pushkin <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/168/head:pull/168
$ git checkout pull/168

Update a local copy of the PR:
$ git checkout pull/168
$ git pull https://git.openjdk.org/crac.git pull/168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 168

View PR using the GUI difftool:
$ git pr show -t 168

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/168.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back TimPushkin! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TimPushkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346768: [CRaC] Ignore errors parsing classpath

Co-authored-by: Timofei Pushkin <[email protected]>
Reviewed-by: rvansa

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the crac branch:

• a2fb688: 8346766: [CRaC] tools/launcher/HelpFlagsTest.java and tools/launcher/VersionCheck.java tests fail on Windows
• 2c9ab05: 8346765: [CRaC] Could not find criuengine on Windows and Mac

Please see this link for an up-to-date comparison between the source branch of this pull request and the crac branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rvansa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

⚠️ @TimPushkin the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8346768
$ git commit --author='Preferred Full Name <[email protected]>' --allow-empty -m 'Update full name'
$ git push

[TimPushkin]

/contributor add tpushkin

[openjdk]

@TimPushkin
Contributor Timofei Pushkin <[email protected]> successfully added.

[mlbridge]

Webrevs

• 00: Full (5f572b78)

[rvansa]

LGTM, thanks!

[TimPushkin]

/integrate

[openjdk]

@TimPushkin
Your change (at version 5f572b7) is now ready to be sponsored by a Committer.