8335231: [macos] Test java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java failed on macOS because the case didn't get the expected PrintAbortException #20027
+5
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a printjob is cancelled midway,
PrinterAbortException
was not thrown in macos. becausefirstly,
cancelCheck
invokesLWCToolkit.invokeLater
with null as parameter causing it to fail with NPE andsecondly PrinterAbortException was consumed silently when
printLoop
throws any exceptionwhich is rectified to throw the PrinterAbortException when encountered..
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20027/head:pull/20027
$ git checkout pull/20027
Update a local copy of the PR:
$ git checkout pull/20027
$ git pull https://git.openjdk.org/jdk.git pull/20027/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20027
View PR using the GUI difftool:
$ git pr show -t 20027
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20027.diff
Webrev
Link to Webrev Comment