Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335231: [macos] Test java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java failed on macOS because the case didn't get the expected PrintAbortException #20027

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jul 4, 2024

When a printjob is cancelled midway, PrinterAbortException was not thrown in macos. because
firstly, cancelCheck invokes LWCToolkit.invokeLater with null as parameter causing it to fail with NPE and
secondly PrinterAbortException was consumed silently when printLoop throws any exception
which is rectified to throw the PrinterAbortException when encountered..


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8335231: [macos] Test java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java failed on macOS because the case didn't get the expected PrintAbortException (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20027/head:pull/20027
$ git checkout pull/20027

Update a local copy of the PR:
$ git checkout pull/20027
$ git pull https://git.openjdk.org/jdk.git pull/20027/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20027

View PR using the GUI difftool:
$ git pr show -t 20027

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20027.diff

Webrev

Link to Webrev Comment

…el.java failed on macOS because the case didn't get the expected PrintAbortException
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2024

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 4, 2024
@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jul 4, 2024

Webrevs

Copy link
Contributor

@TejeshR13 TejeshR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did verified in MacOS and the fix is working fine. The issue is in windows too, getting the same error. Is there a separate bug for windows?

@prsadhuk
Copy link
Contributor Author

prsadhuk commented Jul 5, 2024

I am not able to reproduce in windows, and I guess neither the submitter who raised this issue as it is mentioned in JBS
Is it a platform-specific issue: Yes. This issue only happens on macOS.
Maybe there is some issue in your physical printer configuration in which case you can try with "Microsoft Print-to-pdf" option

@TejeshR13
Copy link
Contributor

I am not able to reproduce in windows, and I guess neither the submitter who raised this issue as it is mentioned in JBS Is it a platform-specific issue: Yes. This issue only happens on macOS. Maybe there is some issue in your physical printer configuration in which case you can try with "Microsoft Print-to-pdf" option

Yeah, Print-to-pdf works fine. Not sure about printer config issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
2 participants