Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335727: since-checker: Add @since tags to ClassFile::transformClass and CodeBuilder #20041

Closed
wants to merge 1 commit into from

Conversation

nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented Jul 4, 2024

Please review this simple doc only change.
Some methods in ClassFile API were renamed recently as part of JDK-8335290 and JDK-8335110 and need to have @since 24, as they are essentially new methods.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8335727: since-checker: Add @<!---->since tags to ClassFile::transformClass and CodeBuilder (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20041/head:pull/20041
$ git checkout pull/20041

Update a local copy of the PR:
$ git checkout pull/20041
$ git pull https://git.openjdk.org/jdk.git pull/20041/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20041

View PR using the GUI difftool:
$ git pr show -t 20041

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20041.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2024

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 4, 2024
@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@nizarbenalla The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jul 4, 2024

Webrevs

Copy link
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot that renames are new additions too! I am too ignorant.

@nizarbenalla
Copy link
Member Author

No worries! I noticed these by chance today.

@asotona
Copy link
Member

asotona commented Jul 8, 2024

Just FYI: move from preview to final will bump all @since tags and remove obsolete method-level @since tags (as they become equal to the class-level tag).

see: #19826

@nizarbenalla
Copy link
Member Author

Thank you, I created this PR because the test in #18934 failed when I was running it. If ClassFile goes final before the checker is integrated then this should be fine.

@nizarbenalla
Copy link
Member Author

I will close this for now.

@nizarbenalla nizarbenalla deleted the classfile-tags branch September 19, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants