Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337111: Bad HTML checker for generated documentation #22866

Open
wants to merge 1 commit into
base: jdk24
Choose a base branch
from

Conversation

nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented Dec 23, 2024

Hi all,

This pull request contains a backport of commit ed292318 from the openjdk/jdk repository.

The commit being backported was authored by Nizar Benalla on 23 Dec 2024 and was reviewed by Hannes Wallnöfer.

Thanks!

Note: #22844 needs to be integrated before this change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8337111: Bad HTML checker for generated documentation (Sub-task - P4)
  • JDK-8337113: Bad character checker for generated documentation (Sub-task - P4)
  • JDK-8337116: Internal links checker for generated documentation (Sub-task - P4)
  • JDK-8337114: DocType checker for generated documentation (Sub-task - P4)
  • JDK-8337117: External links checker for generated documentation (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22866/head:pull/22866
$ git checkout pull/22866

Update a local copy of the PR:
$ git checkout pull/22866
$ git pull https://git.openjdk.org/jdk.git pull/22866/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22866

View PR using the GUI difftool:
$ git pr show -t 22866

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22866.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2024

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ed292318a98163b3226aa05d06825b48c3d97dbb 8337111: Bad HTML checker for generated documentation Dec 23, 2024
@openjdk
Copy link

openjdk bot commented Dec 23, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 23, 2024
@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@nizarbenalla To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@nizarbenalla
Copy link
Member Author

/issue add 8346780

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@nizarbenalla
Adding additional issue to issue list: 8346780: External links checker for generated documentation.

@nizarbenalla
Copy link
Member Author

/issue remove 8346780
/issue add 8337117

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@nizarbenalla
Removing additional issue from issue list: 8346780.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@nizarbenalla
Adding additional issue to issue list: 8337117: External links checker for generated documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant