Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346457: AOT cache creation crashes with "assert(pair_at(i).match() < pair_at(i+1).match()) failed: unsorted table entries" #22871

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented Dec 23, 2024

Avoid calling InstanceKlass::compute_has_loops_flag_for_methods() when a class has failed verification during CDS dump. It is to avoid assert in subsequent byte code verification such as in Bytecode_lookupswitch::verify().

Testing: tiers 1 - 4.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346457: AOT cache creation crashes with "assert(pair_at(i).match() < pair_at(i+1).match()) failed: unsorted table entries" (Bug - P2)(⚠️ The fixVersion in this issue is [24] but the fixVersion in .jcheck/conf is 25, a new backport will be created when this pr is integrated.)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22871/head:pull/22871
$ git checkout pull/22871

Update a local copy of the PR:
$ git checkout pull/22871
$ git pull https://git.openjdk.org/jdk.git pull/22871/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22871

View PR using the GUI difftool:
$ git pr show -t 22871

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22871.diff

… pair_at(i+1).match()) failed: unsorted table entries"
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2024

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@calvinccheung The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant