-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8346831: Remove the extra closing parenthesis in CTW Makefile #22878
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back qxing! A progress list of the required criteria for merging this PR into |
@MaxXSoft This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@liach, @kimbarrett, @lmesnik) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix. Let's wait for another build reviewer.
/reviewers 2 reviewer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@liach @kimbarrett @lmesnik Thanks for the review! It looks like the macOS x64 tier1 gc test timed out, I'm rerunning it. Although this patch has nothing to do with it. /integrate |
JDK-8322982 updated the Makefile in
test/hotspot/jtreg/testlibrary/ctw
to fix a previous issue with the Class-File API, which was later partially reverted by JDK-8334733 because the Class-File API left preview, but left an extra closing parenthesis in the Makefile, which caused CTW to fail to build.This patch removes the extra parenthesis in the Makefile.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22878/head:pull/22878
$ git checkout pull/22878
Update a local copy of the PR:
$ git checkout pull/22878
$ git pull https://git.openjdk.org/jdk.git pull/22878/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22878
View PR using the GUI difftool:
$ git pr show -t 22878
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22878.diff
Using Webrev
Link to Webrev Comment