Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347427: JTabbedPane/8134116/Bug8134116.java has no license header #23034

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Jan 10, 2025

The file test/jdk/javax/swing/JTabbedPane/8134116/Bug8134116.java has no license header.

I added the GPL header and organised imports.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347427: JTabbedPane/8134116/Bug8134116.java has no license header (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23034/head:pull/23034
$ git checkout pull/23034

Update a local copy of the PR:
$ git checkout pull/23034
$ git pull https://git.openjdk.org/jdk.git pull/23034/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23034

View PR using the GUI difftool:
$ git pr show -t 23034

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23034.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2025

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347427: JTabbedPane/8134116/Bug8134116.java has no license header

Reviewed-by: dmarkov, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 10f7142: 8347295: Fix WinResourceTest to make it work with WiX v4.0+
  • 01c8ba2: 8347298: Bug in JPackageCommand.ignoreFakeRuntime()
  • d69463e: 8347300: Don't exclude the "PATH" var from the environment when running app launchers in jpackage tests
  • 4b554b5: 8346722: (fs) Files.probeContentType throws ClassCastException with custom file system provider
  • 46ba515: 8346669: Increase abstraction in SetupBuildLauncher and remove extra args
  • e7e8f60: 8347302: Mark test tools/jimage/JImageToolTest.java as flagless
  • 9cf7d42: 8346184: C2: assert(has_node(i)) failed during split thru phi
  • 1bf2f5c: 8343510: JFR: Remove AccessControlContext from FlightRecorder::addListener specification
  • beb0e60: 8347397: Cleanup of JDK-8169880
  • c5c4efd: 8347120: Launchers should not have java headers on include path
  • ... and 1 more: https://git.openjdk.org/jdk/compare/12752b0031643b3bf868de50b4455654162b2ee4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 10, 2025
@openjdk
Copy link

openjdk bot commented Jan 10, 2025

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jan 10, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants