-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293123: Fix various include file ordering #23048
Conversation
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these changes are not related to the listed JBS issue but I will leave it up to you if you want to broaden the scope of the issue to cover the more general out-of-order-include problem.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (after David's comment about the title). Thanks for fixing!
Thanks for reviewing Stefan and David. I changed the title. |
Going to push as commit cc19897.
Your commit was automatically rebased without conflicts. |
There were only a couple of files that violated the alphabetical sort order, where jvm.h is sorted as j.
Testing with tier1 sanity.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23048/head:pull/23048
$ git checkout pull/23048
Update a local copy of the PR:
$ git checkout pull/23048
$ git pull https://git.openjdk.org/jdk.git pull/23048/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23048
View PR using the GUI difftool:
$ git pr show -t 23048
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23048.diff
Using Webrev
Link to Webrev Comment