8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid

[myankelev]

• fully automated the test
• removed the race condition
• client on a thread and server on a thread options are now run together automatically

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid (Sub-task - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer) 🔄 Re-review required (review applies to 5e300681)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23469/head:pull/23469
$ git checkout pull/23469

Update a local copy of the PR:
$ git checkout pull/23469
$ git pull https://git.openjdk.org/jdk.git pull/23469/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23469

View PR using the GUI difftool:
$ git pr show -t 23469

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23469.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back myankelev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@myankelev This change is no longer ready for integration - check the PR body for details.

[openjdk]

@myankelev The following labels will be automatically applied to this pull request:

• net
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (2bff4a34)
• 02: Full - Incremental (68c52a37)
• 01: Full - Incremental (5e300681)
• 00: Full (d2f11260)

[dfuch]

The new logic looks good to me. Please wait for a review from someone from security libs before integrating.

[dfuch]

And implementing the suggested changes would be good...

[myankelev]

And implementing the suggested changes would be good...

done, thanks

[bridgekeeper]

@myankelev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[myankelev]

Still in review

[bridgekeeper]

@myankelev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[myankelev]

Still needs a security libraries approval

[bridgekeeper]

@myankelev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[myankelev]

Still needs a security libraries approval

[rhalade]

I understand this is a old test and it is not in scope of this bug to update existing code. But there are few issues in this test that should be addressed, for instance, use of deprecated URL, old style threads, old code styles, typos etc. Can you please check the complete test code as if you are to rewrite?

[myankelev]

I understand this is a old test and it is not in scope of this bug to update existing code. But there are few issues in this test that should be addressed, for instance, use of deprecated URL, old style threads, old code styles, typos etc. Can you please check the complete test code as if you are to rewrite?

Updated the code

[bridgekeeper]

@myankelev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!