8350572: ZGC: Enhance z_verify_safepoints_are_blocked interactions with VMError

[xmas92]

If VMError reporting is triggered from a disallowed thread state z_verify_safepoints_are_blocked will cause reentrant assertions to be triggered, when for example when loading the thread oop as part of thread printing. This extends the verification to be ignored if triggered from the thread doing the error reporting. In most cases performing the load barriers from disallowed thread states during error reporting will work.

Testing:

• tier 1 Oracle supported platforms
• GHA

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350572: ZGC: Enhance z_verify_safepoints_are_blocked interactions with VMError (Bug - P4)

Reviewers

• Erik Österlund (@fisk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23820/head:pull/23820
$ git checkout pull/23820

Update a local copy of the PR:
$ git checkout pull/23820
$ git pull https://git.openjdk.org/jdk.git pull/23820/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23820

View PR using the GUI difftool:
$ git pr show -t 23820

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23820.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350572: ZGC: Enhance z_verify_safepoints_are_blocked interactions with VMError

Reviewed-by: eosterlund

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 63e0fc4: 8350841: ProblemList jdk/incubator/vector/Long256VectorTests.java
• acc6f19: 8350614: [JMH] jdk.incubator.vector.VectorCommutativeOperSharingBenchmark fails
• 01bd7e4: 8350314: Shenandoah: Capture thread state sync times in GC timings
• 4522f12: 8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity
• e4d3c97: 8350111: [PPC] AsyncGetCallTrace crashes when called while handling SIGTRAP

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@xmas92 The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4292be03)

[fisk]

Looks good.