Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8350893: Use generated names for hand generated opto runtime blobs #23829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adinn
Copy link
Contributor

@adinn adinn commented Feb 27, 2025

The two special case opto runtime blobs that support uncommon trap and exception handling are currently being generated using hard wired blob names determined by port-specific code. They should employ the standard blob names generated from shared declarations in file stubDeclarations.hpp.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350893: Use generated names for hand generated opto runtime blobs (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23829/head:pull/23829
$ git checkout pull/23829

Update a local copy of the PR:
$ git checkout pull/23829
$ git pull https://git.openjdk.org/jdk.git pull/23829/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23829

View PR using the GUI difftool:
$ git pr show -t 23829

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23829.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 27, 2025

👋 Welcome back adinn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Feb 27, 2025

@adinn The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-compiler [email protected] rfr Pull request is ready for review labels Feb 27, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 27, 2025

Webrevs

@adinn adinn changed the title JKK-8350893: Use generated names for hand generated opto runtime blobs JDK-8350893: Use generated names for hand generated opto runtime blobs Feb 27, 2025
@openjdk openjdk bot changed the title JDK-8350893: Use generated names for hand generated opto runtime blobs 8350893: Use generated names for hand generated opto runtime blobs Feb 27, 2025
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. It looks like in release builds all of these would be "runtime stub"? Is that expected?

const char* OptoRuntime::stub_name(address entry) {
#ifndef PRODUCT
  CodeBlob* cb = CodeCache::find_blob(entry);
  RuntimeStub* rs =(RuntimeStub *)cb;
  assert(rs != nullptr && rs->is_runtime_stub(), "not a runtime stub");
  return rs->name();
#else
  // Fast implementation for product mode (maybe it should be inlined too)
  return "runtime stub";
#endif
}

@@ -206,7 +207,8 @@ void OptoRuntime::generate_exception_blob() {

// setup code generation tools
// Measured 8/7/03 at 256 in 32bit debug build
CodeBuffer buffer("exception_blob", 600, 512);
const char* name = OptoRuntime::stub_name(OptoStubId::uncommon_trap_id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo. Should be exception_id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants