-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8350893: Use generated names for hand generated opto runtime blobs #23829
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back adinn! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. It looks like in release builds all of these would be "runtime stub"? Is that expected?
const char* OptoRuntime::stub_name(address entry) {
#ifndef PRODUCT
CodeBlob* cb = CodeCache::find_blob(entry);
RuntimeStub* rs =(RuntimeStub *)cb;
assert(rs != nullptr && rs->is_runtime_stub(), "not a runtime stub");
return rs->name();
#else
// Fast implementation for product mode (maybe it should be inlined too)
return "runtime stub";
#endif
}
@@ -206,7 +207,8 @@ void OptoRuntime::generate_exception_blob() { | |||
|
|||
// setup code generation tools | |||
// Measured 8/7/03 at 256 in 32bit debug build | |||
CodeBuffer buffer("exception_blob", 600, 512); | |||
const char* name = OptoRuntime::stub_name(OptoStubId::uncommon_trap_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo. Should be exception_id
The two special case opto runtime blobs that support uncommon trap and exception handling are currently being generated using hard wired blob names determined by port-specific code. They should employ the standard blob names generated from shared declarations in file stubDeclarations.hpp.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23829/head:pull/23829
$ git checkout pull/23829
Update a local copy of the PR:
$ git checkout pull/23829
$ git pull https://git.openjdk.org/jdk.git pull/23829/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23829
View PR using the GUI difftool:
$ git pr show -t 23829
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23829.diff
Using Webrev
Link to Webrev Comment