8350903: Remove explicit libjvm.so dependency for libVThreadEventTest #23835
+1
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the test fix that removes
libVThreadEventTest
explicit dependency tolibjvm
, by removing the call toJNI_GetCreatedJavaVMs
inAgent_OnAttach
. There is avm
argument passed viaAgent_OnAttach
. With the change,libVThreadEventTest
no longer needs to be linked withlibjvm.so
(orjvm.dll
).VThreadEventTest.java
now runs on both dynamic and static JDK.Tested on static JDK locally
GHA: https://github.com/jianglizhou/jdk/actions/runs/13577993687/job/37960245161
Progress
Issue
Reviewers without OpenJDK IDs
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23835/head:pull/23835
$ git checkout pull/23835
Update a local copy of the PR:
$ git checkout pull/23835
$ git pull https://git.openjdk.org/jdk.git pull/23835/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23835
View PR using the GUI difftool:
$ git pr show -t 23835
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23835.diff
Using Webrev
Link to Webrev Comment