Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8350903: Remove explicit libjvm.so dependency for libVThreadEventTest #23835

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jianglizhou
Copy link
Contributor

@jianglizhou jianglizhou commented Feb 28, 2025

Please review the test fix that removes libVThreadEventTest explicit dependency to libjvm, by removing the call to JNI_GetCreatedJavaVMs in Agent_OnAttach. There is a vm argument passed via Agent_OnAttach. With the change, libVThreadEventTest no longer needs to be linked with libjvm.so (or jvm.dll). VThreadEventTest.java now runs on both dynamic and static JDK.

Tested on static JDK locally
GHA: https://github.com/jianglizhou/jdk/actions/runs/13577993687/job/37960245161


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350903: Remove explicit libjvm.so dependency for libVThreadEventTest (Bug - P4)

Reviewers without OpenJDK IDs

  • @mScott224 (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23835/head:pull/23835
$ git checkout pull/23835

Update a local copy of the PR:
$ git checkout pull/23835
$ git pull https://git.openjdk.org/jdk.git pull/23835/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23835

View PR using the GUI difftool:
$ git pr show -t 23835

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23835.diff

Using Webrev

Link to Webrev Comment

Remove explicitly linking with libjvm.so for libVThreadEventTest.
Remove `BUILD_HOTSPOT_JTREG_LIBRARIES_JDK_LIBS_libVThreadEventTest := java.base:libjvm` for Windows.
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2025

👋 Welcome back jiangli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2025
@openjdk
Copy link

openjdk bot commented Feb 28, 2025

@jianglizhou The following labels will be automatically applied to this pull request:

  • build
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Feb 28, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants