8350854: Include thread counts in safepoint logging #23838
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to add thread counts in safepoint logging. In recent work, we notice the number of Java thread may affects time to reach/leave safepoint hardly in some cases, but safepoint logging doesn't have thread counts, thread counts are printed only with 'safepoint+stats' log.
Given in many cases, we only have
safepoint
log enabled, notsafepoint+stats
, it make sense to add thread count to 'safepoint' logging.Here is example log output with the change:
Test
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23838/head:pull/23838
$ git checkout pull/23838
Update a local copy of the PR:
$ git checkout pull/23838
$ git pull https://git.openjdk.org/jdk.git pull/23838/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23838
View PR using the GUI difftool:
$ git pr show -t 23838
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23838.diff
Using Webrev
Link to Webrev Comment