Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8350854: Include thread counts in safepoint logging #23838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pengxiaolong
Copy link

@pengxiaolong pengxiaolong commented Feb 28, 2025

The PR is to add thread counts in safepoint logging. In recent work, we notice the number of Java thread may affects time to reach/leave safepoint hardly in some cases, but safepoint logging doesn't have thread counts, thread counts are printed only with 'safepoint+stats' log.

Given in many cases, we only have safepoint log enabled, not safepoint+stats, it make sense to add thread count to 'safepoint' logging.

Here is example log output with the change:

[15.240s][info][safepoint      ] Safepoint "ShenandoahFinalMarkStartEvac", Time since last: 3527459 ns, Reaching safepoint: 78666 ns, At safepoint: 821625 ns, Leaving safepoint: 1472167 ns, Total: 2372458 ns, Threads: 3 runnable, 1038 total

Test

  • Tire1
  • Tire2

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350854: Include thread counts in safepoint logging (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23838/head:pull/23838
$ git checkout pull/23838

Update a local copy of the PR:
$ git checkout pull/23838
$ git pull https://git.openjdk.org/jdk.git pull/23838/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23838

View PR using the GUI difftool:
$ git pr show -t 23838

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23838.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2025

👋 Welcome back xpeng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Feb 28, 2025

@pengxiaolong The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@pengxiaolong pengxiaolong marked this pull request as ready for review February 28, 2025 15:57
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant