-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8286204: [Accessibility,macOS,VoiceOver] VoiceOver reads the spinner value 10 as 1 when user iterates to 10 for the first time on macOS #23841
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@kumarabhi006 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the fix on macOS 15.3.1. The fix works intermittently for me. It announces percentage most of the time and then suddenly just a number.
Follow these steps to test the behaviour: | ||
1. Start the VoiceOver (Press Commaand + F5) application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Start the VoiceOver (Press Commaand + F5) application | |
1. Start the VoiceOver (Press Command + F5) application |
@azuev-java please review |
VoiceOver is unable to announce the correct value for spinner. For JSpinner with maximum value of more than 10, VO announce 10 as 1, 20 as 2 and so on. Probable reason is the "ACCESSIBLE_TEXT_PROPERTY" fired by accessible JTextComponent that leads to wrong range value invoked for accessibility API by VO.
Workaround fix is to ensure "ACCESSIBLE_TEXT_PROPOERTY" is not fired in case of JSpinner with numeric values.
Since the fix is in Java Component, verified fix with JAWS on windows. I don't see any side effects in announcement.
Manual test case is added to verify the fix.
CI pipeline testing is ok for the proposed fix.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23841/head:pull/23841
$ git checkout pull/23841
Update a local copy of the PR:
$ git checkout pull/23841
$ git pull https://git.openjdk.org/jdk.git pull/23841/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23841
View PR using the GUI difftool:
$ git pr show -t 23841
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23841.diff
Using Webrev
Link to Webrev Comment