8224968: javax/swing/JColorChooser/Test6827032.java times out in Windows 10

[aivanov-jdk]

Problem:

The test hangs intermittently when run on Windows. (In some cases, handling the timeout takes 2 hours.)

Thread dump shows no AWT threads, yet jtreg harness still waits for the test thread to finish, in particular it waits for StreamCopier. See threaddump.log attached to the bug and my comment for more details.

Fix, or Workaround:

Drag mouse for a short while.

In my testing on CI, the javax/swing/JColorChooser/Test6827032.java failed on Windows 3 times out of 6 runs with 20 repeats (JTREG=REPEAT_COUNT=20) without the fix.

There have been no failures after the fix in 10 runs with 20 repeats.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8224968: javax/swing/JColorChooser/Test6827032.java times out in Windows 10 (Bug - P4)

Reviewers

• Alexander Zvegintsev (@azvegint - Reviewer)
• Damon Nguyen (@DamonGuy - Committer)

Reviewers without OpenJDK IDs

• @abdelhak-zaaim (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23846/head:pull/23846
$ git checkout pull/23846

Update a local copy of the PR:
$ git checkout pull/23846
$ git pull https://git.openjdk.org/jdk.git pull/23846/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23846

View PR using the GUI difftool:
$ git pr show -t 23846

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23846.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8224968: javax/swing/JColorChooser/Test6827032.java times out in Windows 10

Reviewed-by: azvegint, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 197004f: 8350820: OperatingSystemMXBean CpuLoad() methods return -1.0 on Windows
• e98df71: 8348028: Unable to run gtests with CDS enabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@aivanov-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[aivanov-jdk]

JDK-8197825 was a test stabilisation fix, we don't add such bugs into the @bug tag.

[mlbridge]

Webrevs

• 00: Full (83cfbc0e)

[azvegint]

Thread dump shows no AWT threads, yet jtreg harness still waits for the test thread to finish, in particular it waits for StreamCopier. See threaddump.log attached to the bug and my comment for more details.

This looks like we should file an issue against jtreg, as I don't see anything wrong with the test either.

[aivanov-jdk]

Thread dump shows no AWT threads, yet jtreg harness still waits for the test thread to finish, in particular it waits for StreamCopier. See threaddump.log attached to the bug and my comment for more details.

This looks like we should file an issue against jtreg, as I don't see anything wrong with the test either.

Yes. I'd like to start an internal discussion first and then submit a bug.

[DamonGuy]

Interesting workaround. Works nicely from what I can tell. Agreed that I don't see anything particularly wrong with the test itself, but this change works. The additional time of dragging barely adds any time to the test too, which is nice.