8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA

[JoeWang-Java]

Fix handleCharacters by adding a guard to zero length and letting the rest of the process continue (e.g. closing tags and etc).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349516: StAXStream2SAX.handleCharacters() fails on empty CDATA (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23847/head:pull/23847
$ git checkout pull/23847

Update a local copy of the PR:
$ git checkout pull/23847
$ git pull https://git.openjdk.org/jdk.git pull/23847/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23847

View PR using the GUI difftool:
$ git pr show -t 23847

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23847.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@JoeWang-Java The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (2d4b7653)
• 00: Full (70fc2ca5)

[naotoj]

Hi Joe,
The comment above this piece reads:

        // workaround for bugid 5046319 - switch over to commented section
        // below when it is fixed.

And the bug 5046319 (closed issue about AIOOBE) is fixed. Should the commented section be considered?

[JoeWang-Java]

Hi Naoto,

Yes, I did look through that code and bug 5046319. Unfortunately, it happened when JAXP was standalone, the history of the change was lost.
The variable "buf" seems to be an instance variable that serves to cache the text read. That part had been changed as well. Furthermore, if buf starts with zero length, the call to getTextCharacters would still result in IndexOutOfBoundsException.

Maybe the commented code can be removed, I kept them as is in case they may be useful reference as a history.

[naotoj]

OK, then I'd suggest removing the above comment and commented section altogether, as it only provides confusion.

[JoeWang-Java]

Yeah, agree. The code is stable as is.