8350892: [JVMCI] Align ResolvedJavaType.getInstanceFields with Class.getDeclaredFields

[dougxc]

The current order of fields returned by ResolvedJavaType.getInstanceFields is a) not well specified and b) different than the order of fields used almost everywhere else in HotSpot. This PR aligns the order of getInstanceFields with Class.getDeclaredFields().

There is a second commit in this PR that makes ciInstanceKlass::_nonstatic_fields also use the same order which unifies how deoptimization treats fields across C2 and JVMCI. While this commit could be removed, the unification is nice and I cannot see a major downside to it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8350892: [JVMCI] Align ResolvedJavaType.getInstanceFields with Class.getDeclaredFields (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23849/head:pull/23849
$ git checkout pull/23849

Update a local copy of the PR:
$ git checkout pull/23849
$ git pull https://git.openjdk.org/jdk.git pull/23849/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23849

View PR using the GUI difftool:
$ git pr show -t 23849

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23849.diff

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.