8265754: Move suspend/resume API from HandshakeState

[toxaart]

Hi,

in this PR the suspend/resume methods are moved away from the HandshakeState class into a new separate class HandshakeSuspender. The idea is that the state class should be a state keeper and should not be responsible for actions which change the state. Such actions should be done by a separate class.

Tested in tiers 1-4.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8265754: Move suspend/resume API from HandshakeState (Enhancement - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25407/head:pull/25407
$ git checkout pull/25407

Update a local copy of the PR:
$ git checkout pull/25407
$ git pull https://git.openjdk.org/jdk.git pull/25407/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25407

View PR using the GUI difftool:
$ git pr show -t 25407

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25407.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back toxaart! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@toxaart This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265754: Move suspend/resume API from HandshakeState

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• aea32ec: 8357647: Stream gatherers forward upstream size information to downstream
• f62b978: 8357448: AOT crashes on linux musl with AddReads.java
• 7cb6e5e: 8353124: java/lang/Thread/virtual/stress/Skynet.java#Z times out on macosx-x64-debug
• ... and 9 more: https://git.openjdk.org/jdk/compare/bd095896dd6e3fccb932f3d9823008766e9ab18d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@toxaart The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0ee1abf2)
• 00: Full (b852ba9c)

[dholmes-ora]

This refactoring seems okay to me.

Thanks

[pchilano]

In order to fully move suspend/resume code outside of HandshakeState we should also move _suspended/_async_suspend_handshake, otherwise we are just adding an extra indirection with class HandshakeSuspender IMO. The idea behind this bug was to define suspend/resume and related HandshakeClosure definitions without needing extra knowledge in HandshakeState, like any other HandshakeClosures. The reason why this is not straightforward is because of the interaction with the HandshakeState lock. But if we are going to give access to it to HandshakeSuspender we might as well give it to JavaThread instead and move everything there as that’s where all methods naturally belong. Something like this: pchilano@4e87006