Skip to content

8357559: G1HeapRegionManager refactor rename functions related to the number of regions in different states #25408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

walulyai
Copy link
Member

@walulyai walulyai commented May 23, 2025

Hi,

Please review this refactoring of functions names in G1HeapRegionManager and removing duplicate methods.

Testing: gha


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357559: G1HeapRegionManager refactor rename functions related to the number of regions in different states (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25408/head:pull/25408
$ git checkout pull/25408

Update a local copy of the PR:
$ git checkout pull/25408
$ git pull https://git.openjdk.org/jdk.git pull/25408/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25408

View PR using the GUI difftool:
$ git pr show -t 25408

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25408.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2025

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2025

@walulyai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357559: G1HeapRegionManager refactor rename functions related to the number of regions in different states

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 114 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 23, 2025

@walulyai The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@walulyai walulyai marked this pull request as ready for review May 23, 2025 10:55
@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2025
@mlbridge
Copy link

mlbridge bot commented May 23, 2025

Webrevs

@albertnetymk
Copy link
Member

/cc hotspot-gc

@openjdk
Copy link

openjdk bot commented May 27, 2025

@albertnetymk
The hotspot-gc label was successfully added.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 27, 2025
@walulyai
Copy link
Member Author

Thanks for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented May 27, 2025

Going to push as commit 67d4ed1.
Since your change was applied there have been 120 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 27, 2025
@openjdk openjdk bot closed this May 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 27, 2025
@openjdk
Copy link

openjdk bot commented May 27, 2025

@walulyai Pushed as commit 67d4ed1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants