8357649: IGV: add block index to the supplemental node properties

[mhaessig]

This PR adds the block index to IGV node properties as soon as the CFG has been scheduled. This is really handy when working on peepholes, where one has to work with block indices.

Testing:

• Github Actions
• tier1, tier2, and some Oracle internal testing on Oracle supported platfors and OSs

Shout out to @robcasloz for coming up with an initial version of this patch.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357649: IGV: add block index to the supplemental node properties (Enhancement - P4)

Reviewers

• Roberto Castañeda Lozano (@robcasloz - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Contributors

• Roberto Castañeda Lozano <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25414/head:pull/25414
$ git checkout pull/25414

Update a local copy of the PR:
$ git checkout pull/25414
$ git pull https://git.openjdk.org/jdk.git pull/25414/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25414

View PR using the GUI difftool:
$ git pr show -t 25414

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25414.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357649: IGV: add block index to the supplemental node properties

Co-authored-by: Roberto Castañeda Lozano <[email protected]>
Reviewed-by: rcastanedalo, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• a50d3be: 8312198: [macos] metal pipeline - window rendering stops after display sleep
• aac287e: 8353581: Support for import module in JShell's code completion
• 4a4209f: 8357685: Change the type of Integer::digits from char[] to byte[]
• ... and 16 more: https://git.openjdk.org/jdk/compare/48df41b6997cfe2c8aa3bc46ea25eff01f615d31...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@robcasloz, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@mhaessig The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mhaessig]

/contributor add @robcasloz

[openjdk]

@mhaessig
Contributor Roberto Castañeda Lozano <[email protected]> successfully added.

[mlbridge]

Webrevs

• 00: Full (bb149db5)

[robcasloz]

Looks good, thanks!

[chhagedorn]

Looks good to me, too!

[mhaessig]

Thank you both for your reviews!

/integrate

[openjdk]

@mhaessig
Your change (at version bb149db) is now ready to be sponsored by a Committer.

[robcasloz]

/sponsor

[openjdk]

Going to push as commit a37e826.
Since your change was applied there have been 21 commits pushed to the master branch:

• 3dbd2d3: 8347570: Configure fails on macOS if directory name do not have correct case
• 99f33b4: 8357568: IGV: Show NULL and numbers up to 4 characters in "Condense graph" filter
• a50d3be: 8312198: [macos] metal pipeline - window rendering stops after display sleep
• ... and 18 more: https://git.openjdk.org/jdk/compare/48df41b6997cfe2c8aa3bc46ea25eff01f615d31...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robcasloz @mhaessig Pushed as commit a37e826.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.