-
Notifications
You must be signed in to change notification settings - Fork 5.9k
8357649: IGV: add block index to the supplemental node properties #25414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into |
@mhaessig This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@robcasloz, @chhagedorn) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/contributor add @robcasloz |
@mhaessig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, too!
Thank you both for your reviews! /integrate |
/sponsor |
Going to push as commit a37e826.
Your commit was automatically rebased without conflicts. |
@robcasloz @mhaessig Pushed as commit a37e826. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR adds the block index to IGV node properties as soon as the CFG has been scheduled. This is really handy when working on peepholes, where one has to work with block indices.
Testing:
Shout out to @robcasloz for coming up with an initial version of this patch.
Progress
Issue
Reviewers
Contributors
<[email protected]>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25414/head:pull/25414
$ git checkout pull/25414
Update a local copy of the PR:
$ git checkout pull/25414
$ git pull https://git.openjdk.org/jdk.git pull/25414/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25414
View PR using the GUI difftool:
$ git pr show -t 25414
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25414.diff
Using Webrev
Link to Webrev Comment