Skip to content

8357649: IGV: add block index to the supplemental node properties #25414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mhaessig
Copy link
Contributor

@mhaessig mhaessig commented May 23, 2025

This PR adds the block index to IGV node properties as soon as the CFG has been scheduled. This is really handy when working on peepholes, where one has to work with block indices.

Screenshot from 2025-05-23 15-35-29

Testing:

  • Github Actions
  • tier1, tier2, and some Oracle internal testing on Oracle supported platfors and OSs

Shout out to @robcasloz for coming up with an initial version of this patch.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357649: IGV: add block index to the supplemental node properties (Enhancement - P4)

Reviewers

Contributors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25414/head:pull/25414
$ git checkout pull/25414

Update a local copy of the PR:
$ git checkout pull/25414
$ git pull https://git.openjdk.org/jdk.git pull/25414/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25414

View PR using the GUI difftool:
$ git pr show -t 25414

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25414.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2025

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2025

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357649: IGV: add block index to the supplemental node properties

Co-authored-by: Roberto Castañeda Lozano <[email protected]>
Reviewed-by: rcastanedalo, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@robcasloz, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2025
@openjdk
Copy link

openjdk bot commented May 23, 2025

@mhaessig The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mhaessig
Copy link
Contributor Author

/contributor add @robcasloz

@openjdk
Copy link

openjdk bot commented May 23, 2025

@mhaessig
Contributor Roberto Castañeda Lozano <[email protected]> successfully added.

@mlbridge
Copy link

mlbridge bot commented May 23, 2025

Webrevs

Copy link
Contributor

@robcasloz robcasloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 23, 2025
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, too!

@mhaessig
Copy link
Contributor Author

Thank you both for your reviews!

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 26, 2025
@openjdk
Copy link

openjdk bot commented May 26, 2025

@mhaessig
Your change (at version bb149db) is now ready to be sponsored by a Committer.

@robcasloz
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 26, 2025

Going to push as commit a37e826.
Since your change was applied there have been 21 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 26, 2025
@openjdk openjdk bot closed this May 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 26, 2025
@openjdk
Copy link

openjdk bot commented May 26, 2025

@robcasloz @mhaessig Pushed as commit a37e826.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants