8357647 : Stream gatherers forward upstream size information to downstream

[viktorklang-ora]

While it could be argued that unbounded Spliterators should not report SIZED / SUBSIZED, GatherSink should report an unknown emission size, so switching to downstream.begin(-1) rather than downstream.begin(size).

Includes a regression test which yields an OOME if this change is omitted.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357647: Stream gatherers forward upstream size information to downstream (Bug - P3)

Reviewers

• Chen Liang (@liach - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25418/head:pull/25418
$ git checkout pull/25418

Update a local copy of the PR:
$ git checkout pull/25418
$ git pull https://git.openjdk.org/jdk.git pull/25418/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25418

View PR using the GUI difftool:
$ git pr show -t 25418

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25418.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vklang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357647: Stream gatherers forward upstream size information to downstream

Reviewed-by: liach, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

• a300c35: 8357105: C2: compilation fails with "assert(false) failed: empty program detected during loop optimization"
• bd09589: 8356632: Fix remaining {@link/@linkplain} tags with refer to private/protected types in java.base
• daa8eda: 8357056: RISC-V: Asm fixes - load/store width
• ... and 51 more: https://git.openjdk.org/jdk/compare/428d33ef3ca0af34d8f164fe9d9b722e81e866a7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@viktorklang-ora The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2810917b)

[liach]

Looks sensible; an integrator may push an arbitrary number of items to the downstream.

[mariokhoury4]

Hi @mariokhoury4, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user mariokhoury4" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

• I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

[AlanBateman]

Looks okay, I assume you'll bump the copyright headers before integration.

[viktorklang-ora]

/integrate

[openjdk]

Going to push as commit aea32ec.
Since your change was applied there have been 64 commits pushed to the master branch:

• f62b978: 8357448: AOT crashes on linux musl with AddReads.java
• 7cb6e5e: 8353124: java/lang/Thread/virtual/stress/Skynet.java#Z times out on macosx-x64-debug
• 5924c2d: 8357267: ZGC: Handle APX EGPRs spilling in ZRuntimeCallSpill
• ... and 61 more: https://git.openjdk.org/jdk/compare/428d33ef3ca0af34d8f164fe9d9b722e81e866a7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@viktorklang-ora Pushed as commit aea32ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.