-
Notifications
You must be signed in to change notification settings - Fork 5.9k
8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null #25419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back zUniQueX! A progress list of the required criteria for merging this PR into |
@zUniQueX This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 45 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs, @jaikiran, @liach) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine, will review the csr when its drafted.
I have created a CSR for this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks OK to me. Please update the copyright year on the file from 1999, 2024,
to 1999, 2025,
.
@jaikiran Thanks for spotting this. I've adjusted the copyright year. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update. Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/integrate |
Proxy#getInvocationHandler(Object)
throws aNullPointerException
if the specified argument isnull
. This PR adds the missingthrows
declaration for the NPE.Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25419/head:pull/25419
$ git checkout pull/25419
Update a local copy of the PR:
$ git checkout pull/25419
$ git pull https://git.openjdk.org/jdk.git pull/25419/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25419
View PR using the GUI difftool:
$ git pr show -t 25419
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25419.diff
Using Webrev
Link to Webrev Comment