Skip to content

8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null #25419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zUniQueX
Copy link
Contributor

@zUniQueX zUniQueX commented May 23, 2025

Proxy#getInvocationHandler(Object) throws a NullPointerException if the specified argument is null. This PR adds the missing throws declaration for the NPE.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8357658 to be approved

Issues

  • JDK-8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null (Bug - P4)
  • JDK-8357658: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25419/head:pull/25419
$ git checkout pull/25419

Update a local copy of the PR:
$ git checkout pull/25419
$ git pull https://git.openjdk.org/jdk.git pull/25419/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25419

View PR using the GUI difftool:
$ git pr show -t 25419

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25419.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2025

👋 Welcome back zUniQueX! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2025

@zUniQueX This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357597: Proxy.getInvocationHandler throws NullPointerException instead of IllegalArgumentException for null

Reviewed-by: rriggs, jpai, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 45 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs, @jaikiran, @liach) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2025
@openjdk
Copy link

openjdk bot commented May 23, 2025

@zUniQueX The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented May 23, 2025

Webrevs

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label May 23, 2025
Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, will review the csr when its drafted.

@liach
Copy link
Member

liach commented May 23, 2025

I have created a CSR for this change.

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks OK to me. Please update the copyright year on the file from 1999, 2024, to 1999, 2025,.

@zUniQueX
Copy link
Contributor Author

@jaikiran Thanks for spotting this. I've adjusted the copyright year.

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. Looks good to me.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels May 27, 2025
Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zUniQueX
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 27, 2025
@openjdk
Copy link

openjdk bot commented May 27, 2025

@zUniQueX
Your change (at version 38854aa) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored
Development

Successfully merging this pull request may close these issues.

4 participants