8356997: /etc/krb5.conf parser should not forbid include/includedir directives after sections #25421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes are made:
get
returns the first one andgetAll
returns all joining by spaces.Two new tests added. I also separately confirmed that they are parsed in the same way as MIT krb5. MIT krb5 ignores directory name after "include" but here it's an error.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25421/head:pull/25421
$ git checkout pull/25421
Update a local copy of the PR:
$ git checkout pull/25421
$ git pull https://git.openjdk.org/jdk.git pull/25421/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25421
View PR using the GUI difftool:
$ git pr show -t 25421
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25421.diff
Using Webrev
Link to Webrev Comment