8356997: /etc/krb5.conf parser should not forbid include/includedir directives after sections

[wangweij]

Several changes are made:

1. The "include" and "includedir" directives can appear everywhere, even inside a section or a sub-section. However, it only means the content is inserted here but the included file still need its own full structure -- from section to subsections.
2. The same file can be included multiple times as long as not recursively.
3. Everything is merged. For duplicated values, get returns the first one and getAll returns all joining by spaces.

Two new tests added. I also separately confirmed that they are parsed in the same way as MIT krb5. MIT krb5 ignores directory name after "include" but here it's an error.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8356997: /etc/krb5.conf parser should not forbid include/includedir directives after sections (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25421/head:pull/25421
$ git checkout pull/25421

Update a local copy of the PR:
$ git checkout pull/25421
$ git pull https://git.openjdk.org/jdk.git pull/25421/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25421

View PR using the GUI difftool:
$ git pr show -t 25421

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25421.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (dfabb82a)
• 00: Full (9ab72006)

[myankelev]

I don't think this code is covered by the tests at all.
I have found 2 simple ways to test it:

1. change the line 62-66 in IncludeDup from

for (var inc : List.of("outside", "beginsec", "insec", "insec2",
               "insubsec", "endsubsec", "endsec")) {
           Files.writeString(Path.of(inc), String.format("""
                   [a]
                   b = {
                       c = %s
                   }
                   """, inc));
       }

to

for (var inc : List.of("outside", "beginsec", "insec", "insec2",
                "insubsec", "endsubsec", "endsec")) {
            Files.writeString(Path.of(inc), String.format("""
                    [a]
                    b = 
                    { c = %s
                    }
                    """, inc));
        }

2. change krb5.conf EXAMPLE_3.COM from

   EXAMPLE_3.COM = {
	kdc = kdc.example.com
	kdc = kdc2.example.com
	inner =
	{
		aaa = nnn
	}
   }

to

   EXAMPLE_3.COM = {
	kdc = kdc.example.com
	kdc = kdc2.example.com
	inner =
	{ aaa = nnn
	}
   }

There are other ways to cover this as well as writing it's own test case, however I feel that it might be an overkill for this.
What do you think?

[wangweij]

Good catch. Instead I've enhanced the random test to cover this.

[myankelev]

Thank you :)