Skip to content

8320189: vmTestbase/nsk/jvmti/scenarios/bcinstr/BI02/bi02t001 memory corruption when using -Xcheck:jni #25422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented May 23, 2025

This update is fixing a couple of nsk/jvmti/ scenarios tests.
The tests in a JVMTI ClassFileLoadHook callback provide new class file bytes with the result returned by JNI GetByteArrayElements(). It violates the JVMTI ClassFileLoadHook spec saying:

 "The agent must allocate the space for the modified class file data buffer using the memory allocation function Allocate because the VM is responsible for freeing the new class file data buffer using Deallocate."

Please, see the JVMTI ClassFileLoadHook spec:
https://docs.oracle.com/en/java/javase/24/docs/specs/jvmti.html#ClassFileLoadHook

It is the root cause of a memory corruption detected with the VM option -Xcheck:jni.
The fix is to convert a JNI allocated array returned by GetByteArrayElements() to a JMVTI allocated array. New conversion function jni_array_to_jvmti_allocated() is added to thejvmti_common.hpp.

Testing:

  • ran updated tests individually
  • TBD: submit mach5 tiers 1-6

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8320189: vmTestbase/nsk/jvmti/scenarios/bcinstr/BI02/bi02t001 memory corruption when using -Xcheck:jni (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25422/head:pull/25422
$ git checkout pull/25422

Update a local copy of the PR:
$ git checkout pull/25422
$ git pull https://git.openjdk.org/jdk.git pull/25422/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25422

View PR using the GUI difftool:
$ git pr show -t 25422

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25422.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2025

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented May 23, 2025

@sspitsyn The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2025
@mlbridge
Copy link

mlbridge bot commented May 23, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review serviceability [email protected]
Development

Successfully merging this pull request may close these issues.

1 participant